Skip to content

perf(linter): optimize no-dupe-keys #4292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jul 16, 2024
Merged

perf(linter): optimize no-dupe-keys #4292

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions crates/oxc_linter/src/rules/eslint/no_dupe_keys.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use oxc_ast::{
use oxc_diagnostics::OxcDiagnostic;
use oxc_macros::declare_oxc_lint;
use oxc_span::{GetSpan, Span};
use rustc_hash::FxHashMap;
use rustc_hash::{FxBuildHasher, FxHashMap};

use crate::{context::LintContext, rule::Rule, AstNode};

Expand Down Expand Up @@ -43,7 +43,11 @@ impl Rule for NoDupeKeys {
let AstKind::ObjectExpression(obj_expr) = node.kind() else {
return;
};
let mut map = FxHashMap::default();
let len = obj_expr.properties.len();
if len <= 1 {
return;
}
let mut map = FxHashMap::with_capacity_and_hasher(len, FxBuildHasher);
for prop in &obj_expr.properties {
let ObjectPropertyKind::ObjectProperty(prop) = prop else {
continue;
Expand Down