Skip to content

perf(semantic): reduce cloning CompactStrs when declaring references #4239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
overlookmotel wants to merge 2 commits into from
Closed

perf(semantic): reduce cloning CompactStrs when declaring references #4239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c48c39
perf(semantic): reduce cloning `CompactStr`s when declaring references
overlookmotel Jul 12, 2024
b8f36f0
Add `#[inline]` to reference methods
overlookmotel Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions crates/oxc_semantic/src/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,13 +347,17 @@ impl<'a> SemanticBuilder<'a> {
///
/// # Panics
pub fn declare_reference(&mut self, reference: Reference) -> ReferenceId {
let reference_name = reference.name().clone();
let reference_id = self.symbols.create_reference(reference);
let reference_name = self.symbols.get_reference(reference_id).name();

let current_unresolved_references =
&mut self.unresolved_references[self.current_scope_depth];
if let Some(reference_ids) = current_unresolved_references.get_mut(reference_name) {
reference_ids.push(reference_id);
} else {
current_unresolved_references.insert(reference_name.clone(), vec![reference_id]);
}

self.unresolved_references[self.current_scope_depth]
.entry(reference_name)
.or_default()
.push(reference_id);
reference_id
}

Expand Down
2 changes: 2 additions & 0 deletions crates/oxc_semantic/src/symbol.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,12 @@ impl SymbolTable {
self.redeclare_variables[symbol_id].push(span);
}

#[inline]
pub fn create_reference(&mut self, reference: Reference) -> ReferenceId {
self.references.push(reference)
}

#[inline]
pub fn get_reference(&self, reference_id: ReferenceId) -> &Reference {
&self.references[reference_id]
}
Expand Down