Skip to content

fix(parser): fix asi error diagnostic pointing at invalid text causing crash #4163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jul 10, 2024
Merged

fix(parser): fix asi error diagnostic pointing at invalid text causing crash #4163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/oxc_linter/src/snapshots/button_has_type.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ source: crates/oxc_linter/src/tester.rs
× Expected a semicolon or an implicit semicolon after a statement, but found none
╭─[button_has_type.tsx:1:7]
1 │ button type/>
· ─
· ▲
╰────
help: Try insert a semicolon here

Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_linter/src/snapshots/consistent_indexed_object_style.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,6 @@ source: crates/oxc_linter/src/tester.rs
× Expected a semicolon or an implicit semicolon after a statement, but found none
╭─[consistent_indexed_object_style.tsx:1:10]
1 │ funcction foo(): Record<string, any> {}
· ─
· ▲
╰────
help: Try insert a semicolon here
2 changes: 1 addition & 1 deletion crates/oxc_parser/src/cursor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ impl<'a> ParserImpl<'a> {
/// # Errors
pub(crate) fn asi(&mut self) -> Result<()> {
if !self.can_insert_semicolon() {
let span = Span::new(self.prev_token_end, self.cur_token().start);
let span = Span::new(self.prev_token_end, self.prev_token_end);
return Err(diagnostics::auto_semicolon_insertion(span));
}
if self.at(Kind::Semicolon) {
Expand Down
1 change: 1 addition & 0 deletions tasks/coverage/misc/fail/oxc-4111-1.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
funtransientction as longciiConÞr>ol(cde) {
Loading