fix(isolated-declarations): declare global {} should be kept even if it is not exported#3956
Merged
graphite-app[bot] merged 1 commit intomainfrom Jun 29, 2024
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
A-ast
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #3956 will not alter performanceComparing Summary
|
Contributor
Merge activity
|
Boshen
force-pushed
the
06-28-fix_isolated-declarations_declare_global_should_be_kept_even_if_it_is_not_exported
branch
from
232b2b6 to
31e4c3b
Compare
graphite-app
bot
deleted the
06-28-fix_isolated-declarations_declare_global_should_be_kept_even_if_it_is_not_exported
branch
Merged
Boshen
added a commit
that referenced
this pull request
Jun 29, 2024
## [0.16.1] - 2024-06-29 ### Features - 7b38bde parser: Parse modifiers with `parse_modifiers` (#3948) (DonIsaac) - f64ad4b semantic: Make jsdoc building optional (turned off by default) (#3955) (Boshen) ### Bug Fixes - 51e54f9 codegen: Should print `TSModuleDeclarationKind` instead of just `module` (#3957) (Dunqing) - 31e4c3b isolated-declarations: `declare global {}` should be kept even if it is not exported (#3956) (Dunqing) ### Refactor - 2705df9 linter: Improve diagnostic labeling (#3960) (DonIsaac) - 15ec254 semantic: Remove the unused `Semantic::build2` function (Boshen) Co-authored-by: Boshen <Boshen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close: #3952