Skip to content

perf(diagnostics): optimize string-buffer reallocations #3897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Boshen merged 1 commit into from
Jun 25, 2024
Merged

perf(diagnostics): optimize string-buffer reallocations #3897

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/oxc_diagnostics/src/graphic_reporter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1122,9 +1122,9 @@ impl GraphicalReportHandler {
let mut column = context_data.column();
let mut offset = context_data.span().offset();
let mut line_offset = offset;
let mut line_str = String::with_capacity(context.len());
let mut lines = Vec::with_capacity(1);
let mut iter = context.chars().peekable();
let mut line_str = String::new();
let mut lines = Vec::new();
while let Some(char) = iter.next() {
offset += char.len_utf8();
let mut at_end_of_file = false;
Expand Down