Skip to content

refactor(parser): do not allocate modifiers in the arena#3851

Closed
Boshen wants to merge 1 commit intomainfrom
06-23-refactor_parser_do_not_allocate_modifiers_in_the_arena
Closed

refactor(parser): do not allocate modifiers in the arena#3851
Boshen wants to merge 1 commit intomainfrom
06-23-refactor_parser_do_not_allocate_modifiers_in_the_arena

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Jun 23, 2024

No description provided.

@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Boshen commented Jun 23, 2024

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 23, 2024

CodSpeed Performance Report

Merging #3851 will not alter performance

Comparing 06-23-refactor_parser_do_not_allocate_modifiers_in_the_arena (dca4292) with main (97d59fc)

Summary

✅ 28 untouched benchmarks

@Boshen Boshen force-pushed the 06-23-refactor_parser_use_modifiers_for_parsing branch from 477eb8e to 97d59fc Compare June 23, 2024 12:47
@Boshen Boshen changed the base branch from 06-23-refactor_parser_use_modifiers_for_parsing to main June 23, 2024 12:51
@Boshen Boshen force-pushed the 06-23-refactor_parser_do_not_allocate_modifiers_in_the_arena branch from 37825e9 to dca4292 Compare June 23, 2024 12:51
@Boshen
Copy link
Member Author

Boshen commented Jun 23, 2024

Considering to remove this whole thing.

@Boshen Boshen closed this Jun 23, 2024
@Boshen Boshen deleted the 06-23-refactor_parser_do_not_allocate_modifiers_in_the_arena branch June 23, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant