Skip to content

improve(transformer): avoid reallocating strings #3817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jun 22, 2024
Merged

improve(transformer): avoid reallocating strings #3817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/oxc_transformer/src/typescript/enum.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,7 @@ impl<'a, 'b> VisitMut<'a> for IdentifierReferenceRename<'a, 'b> {
// enum_name.identifier
let ident_reference = IdentifierReference::new(SPAN, self.enum_name.clone());
let object = self.ctx.ast.identifier_reference_expression(ident_reference);
let property = self.ctx.ast.identifier_name(SPAN, &ident.name);
let property = IdentifierName::new(SPAN, ident.name.clone());
Some(self.ctx.ast.static_member_expression(SPAN, object, property, false))
}
_ => None,
Expand Down
4 changes: 2 additions & 2 deletions crates/oxc_transformer/src/typescript/namespace.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,12 +421,12 @@ impl<'a> TypeScript<'a> {

// name.item_name = item_name
fn create_assignment_statement(&self, name: &Atom<'a>, item_name: &Atom<'a>) -> Expression<'a> {
let ident = self.ctx.ast.identifier_reference(SPAN, name.as_str());
let ident = IdentifierReference::new(SPAN, name.clone());
let object = self.ctx.ast.identifier_reference_expression(ident);
let property = IdentifierName::new(SPAN, item_name.clone());
let left = self.ctx.ast.static_member(SPAN, object, property, false);
let left = AssignmentTarget::from(left);
let ident = self.ctx.ast.identifier_reference(SPAN, item_name.as_str());
let ident = IdentifierReference::new(SPAN, item_name.clone());
let right = self.ctx.ast.identifier_reference_expression(ident);
let op = AssignmentOperator::Assign;
self.ctx.ast.assignment_expression(SPAN, op, left, right)
Expand Down