Skip to content

chore(linter): promote no-unreachable to correctness.#3778

Closed
rzvxa wants to merge 1 commit intomainfrom
06-19-chore_linter_promote_no-unreachable_to_correctness
Closed

chore(linter): promote no-unreachable to correctness.#3778
rzvxa wants to merge 1 commit intomainfrom
06-19-chore_linter_promote_no-unreachable_to_correctness

Conversation

@rzvxa
Copy link
Contributor

@rzvxa rzvxa commented Jun 19, 2024

Since now there are no known false positives, We might want to promote this rule to correctness for the next release so we can find out about its possible false negatives/positives if any.

Feel free to close this PR if you find it too soon for this.

@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 19, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-linter Area - Linter label Jun 19, 2024
Copy link
Contributor Author

rzvxa commented Jun 19, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on Graphite Graphite

@rzvxa rzvxa requested a review from Boshen June 19, 2024 18:54
@rzvxa rzvxa marked this pull request as ready for review June 19, 2024 18:54
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 19, 2024

CodSpeed Performance Report

Merging #3778 will not alter performance

Comparing 06-19-chore_linter_promote_no-unreachable_to_correctness (d6f3b76) with main (6ba60e9)

Summary

✅ 21 untouched benchmarks

@Boshen
Copy link
Member

Boshen commented Jun 20, 2024

I'll test again when I prepare release for oxlint.

@rzvxa rzvxa mentioned this pull request Jun 26, 2024
@Boshen
Copy link
Member

Boshen commented Jun 27, 2024

I manually test and change the rule categories before each release. I raised a few issues. Closing for house keeping.

@Boshen Boshen closed this Jun 27, 2024
@Boshen Boshen deleted the 06-19-chore_linter_promote_no-unreachable_to_correctness branch September 11, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants