Skip to content

refactor(transformer): move and simplify TS enum transform entry point #3760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jun 19, 2024
Merged

refactor(transformer): move and simplify TS enum transform entry point #3760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions crates/oxc_transformer/src/typescript/enum.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,26 @@ impl<'a> TypeScriptEnum<'a> {
Self { ctx, enums: FxHashMap::default() }
}

pub fn transform_statement(&mut self, stmt: &mut Statement<'a>, ctx: &TraverseCtx<'a>) {
let new_stmt = match stmt {
Statement::TSEnumDeclaration(ts_enum_decl) => {
self.transform_ts_enum(ts_enum_decl, false, ctx)
}
Statement::ExportNamedDeclaration(decl) => {
if let Some(Declaration::TSEnumDeclaration(ts_enum_decl)) = &decl.declaration {
self.transform_ts_enum(ts_enum_decl, true, ctx)
} else {
None
}
}
_ => None,
};

if let Some(new_stmt) = new_stmt {
*stmt = new_stmt;
}
}

/// ```TypeScript
/// enum Foo {
/// X = 1,
Expand Down
28 changes: 1 addition & 27 deletions crates/oxc_transformer/src/typescript/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,33 +152,7 @@ impl<'a> TypeScript<'a> {
}

pub fn transform_statement(&mut self, stmt: &mut Statement<'a>, ctx: &TraverseCtx<'a>) {
let new_stmt = match stmt {
match_declaration!(Statement) => {
if let Declaration::TSEnumDeclaration(ts_enum_decl) = &stmt.to_declaration() {
self.r#enum.transform_ts_enum(ts_enum_decl, false, ctx)
} else {
None
}
}
match_module_declaration!(Statement) => {
if let ModuleDeclaration::ExportNamedDeclaration(decl) =
stmt.to_module_declaration_mut()
{
if let Some(Declaration::TSEnumDeclaration(ts_enum_decl)) = &decl.declaration {
self.r#enum.transform_ts_enum(ts_enum_decl, true, ctx)
} else {
None
}
} else {
None
}
}
_ => None,
};

if let Some(new_stmt) = new_stmt {
*stmt = new_stmt;
}
self.r#enum.transform_statement(stmt, ctx);
}

pub fn transform_if_statement(&mut self, stmt: &mut IfStatement<'a>) {
Expand Down