Skip to content

fix(minifier): respect join_vars: false option #3724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jun 17, 2024
Merged

fix(minifier): respect join_vars: false option #3724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion crates/oxc_minifier/src/compressor/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,9 @@ impl<'a> VisitMut<'a> for Compressor<'a> {
true
});

self.join_vars(stmts);
if self.options.join_vars {
self.join_vars(stmts);
}

walk_statements_mut(self, stmts);
}
Expand Down
16 changes: 15 additions & 1 deletion crates/oxc_minifier/tests/oxc/folding.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
use crate::{test, test_snapshot};
use oxc_minifier::{CompressOptions, MinifierOptions};

use crate::{test, test_snapshot, test_with_options};

#[test]
fn addition_folding() {
Expand Down Expand Up @@ -37,3 +39,15 @@ fn addition_folding_snapshots() {
],
);
}

#[test]
fn test_join_vars() {
let options = MinifierOptions {
mangle: false,
compress: CompressOptions { join_vars: false, ..CompressOptions::default() },
};
test_with_options("var foo = 1; var bar = 2;", "var foo=1;var bar=2;", options);
// join_vars: true
let options = MinifierOptions::default();
test_with_options("var foo = 1; var bar = 2;", "var foo=1,bar=2;", options);
}