Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
CodSpeed Performance ReportMerging #3591 will not alter performanceComparing Summary
|
|
Should we add this to https://github.com/oxc-project/oxlint-ecosystem-ci/actions/workflows/ecosystem-ci.yml instead 🤔 It's quite difficult to interpret the snapshot results. This also makes the conformance suite even slower to compile :-( |
|
It appears to add 50s to the conformance CI job. If we think this is too high I can move it to the ecosystem CI job, though it may not catch some of the weirder fixes (e.g. labels) |
Let's try and move this to ecosystem CI with fixes applied to running |
|
Moving to oxc-project/oxc-ecosystem-ci#11 |
Makes
cargo coveragerun the linter. It can be run in isolation withcargo coverage linter.The linter is run with fixes and all rules enabled (except nursery rules) in an identical fashion to
oxlint -W all --fix. The fixed code is then re-parsed and checked for errors. Tests will fail if parsing fails or if semantic analysis produces more errors the second time around than when the original source code is analyzed.I've already found several problems with fixes, including 2 panics. One of them was fixed in #3590, and the other is fixed in this PR.