Skip to content

improvement(semantic/cfg): better control flow for DoWhileStatements.#3452

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-28-improvement_semantic_cfg_better_control_flow_for_dowhilestatement_s
Jun 6, 2024
Merged

improvement(semantic/cfg): better control flow for DoWhileStatements.#3452
graphite-app[bot] merged 1 commit intomainfrom
05-28-improvement_semantic_cfg_better_control_flow_for_dowhilestatement_s

Conversation

@rzvxa
Copy link
Contributor

@rzvxa rzvxa commented May 28, 2024

similar to #3451

@graphite-app
Copy link
Contributor

graphite-app bot commented May 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-semantic Area - Semantic label May 28, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented May 28, 2024

CodSpeed Performance Report

Merging #3452 will degrade performances by 3.52%

Comparing 05-28-improvement_semantic_cfg_better_control_flow_for_dowhilestatement_s (91c9995) with main (646b993)

Summary

❌ 1 regressions
✅ 21 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 05-28-improvement_semantic_cfg_better_control_flow_for_dowhilestatement_s Change
transformer[pdf.mjs] 61 ms 63.2 ms -3.52%

@rzvxa rzvxa force-pushed the 05-28-improvement_semantic_cfg_better_control_flow_for_whilestatement_s branch from 4f9dd2c to b9b639d Compare May 28, 2024 13:24
@rzvxa rzvxa force-pushed the 05-28-improvement_semantic_cfg_better_control_flow_for_dowhilestatement_s branch from 384a918 to 22a4d11 Compare May 28, 2024 13:24
@rzvxa rzvxa force-pushed the 05-28-improvement_semantic_cfg_better_control_flow_for_whilestatement_s branch from b9b639d to 357faf8 Compare May 28, 2024 13:30
@rzvxa rzvxa force-pushed the 05-28-improvement_semantic_cfg_better_control_flow_for_dowhilestatement_s branch from 22a4d11 to dc06e60 Compare May 28, 2024 13:30
@rzvxa rzvxa force-pushed the 05-28-improvement_semantic_cfg_better_control_flow_for_whilestatement_s branch from 357faf8 to 23229f3 Compare May 28, 2024 14:48
@rzvxa rzvxa force-pushed the 05-28-improvement_semantic_cfg_better_control_flow_for_dowhilestatement_s branch from dc06e60 to 620cab3 Compare May 28, 2024 14:48
@rzvxa rzvxa force-pushed the 05-28-improvement_semantic_cfg_better_control_flow_for_whilestatement_s branch from 23229f3 to 4ca8863 Compare May 28, 2024 18:06
@rzvxa rzvxa force-pushed the 05-28-improvement_semantic_cfg_better_control_flow_for_dowhilestatement_s branch from 620cab3 to 2bfaa6d Compare May 28, 2024 18:06
@rzvxa rzvxa marked this pull request as ready for review May 30, 2024 20:35
@rzvxa rzvxa force-pushed the 05-28-improvement_semantic_cfg_better_control_flow_for_whilestatement_s branch from 4ca8863 to b26b60b Compare June 5, 2024 19:14
@rzvxa rzvxa force-pushed the 05-28-improvement_semantic_cfg_better_control_flow_for_dowhilestatement_s branch 2 times, most recently from 33b9fcc to b8bd1b8 Compare June 5, 2024 19:28
@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 6, 2024

Merge activity

@Boshen Boshen force-pushed the 05-28-improvement_semantic_cfg_better_control_flow_for_whilestatement_s branch from fa27db7 to 0012094 Compare June 6, 2024 05:41
@Boshen Boshen force-pushed the 05-28-improvement_semantic_cfg_better_control_flow_for_dowhilestatement_s branch from b8bd1b8 to 91c9995 Compare June 6, 2024 05:42
Boshen pushed a commit that referenced this pull request Jun 6, 2024
@Boshen Boshen changed the base branch from 05-28-improvement_semantic_cfg_better_control_flow_for_whilestatement_s to main June 6, 2024 05:47
@graphite-app graphite-app bot merged commit 91c9995 into main Jun 6, 2024
@graphite-app graphite-app bot deleted the 05-28-improvement_semantic_cfg_better_control_flow_for_dowhilestatement_s branch June 6, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant