perf(parser): more efficient number parsing

[overlookmotel]

Follow-on after #3296.

Make parsing binary/octal/hex numeric literals a little more efficient.

These changes all rely on that we know more than the compiler does - that strings passed to these parse_* functions can only contain a certain set of characters.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[overlookmotel]

• perf(parser): more efficient number parsing #3342 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #3342 will not alter performance

_{Comparing 05-18-perf_parser_more_efficient_number_parsing (3673591) with main (6b3d019)}

Summary

✅ 27 untouched benchmarks

[overlookmotel]

@DonIsaac Apologies for code golfing your PR! I got interested after seeing the link to Godbolt you posted in #3296, and wondered if we could push it any further.

Obviously makes little difference in real world as binary/octal/hex literals are rare in JS code, but why not? Though it might inform your approach if you're going to tackle decimal literals too, which are much more common.

I've included Godbolt links showing before/after in the code, if you're interested.

I also tried coaxing the compiler to use SIMD, but no luck: https://godbolt.org/z/sr9r7os1o

[DonIsaac]

@overlookmotel LGTM

[overlookmotel]

Thanks for reviewing @DonIsaac. Appreciate you checking I'm not doing anything stupid!