fix(transformer): do not add __self when JSX is top-level

[overlookmotel]

Fixes a couple of small problems with #3258.

Now does not add __self in a couple of places where there is no this.

1. Top level

const x = <Foo>blah</Foo>;

2. In TS Module Block

declare namespace Foo {
  let x = <Bar>monkey</Bar>;
}

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[overlookmotel]

• fix(transformer): do not add __self when JSX is top-level #3281 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #3281 will not alter performance

_{Comparing 05-14-fix_transformer_do_not_add___self_when_jsx_is_top-level (c8de1d2) with main (482dcc0)}

Summary

✅ 27 untouched benchmarks

[overlookmotel]

I figured out what a TS Module Block is! 😆

[overlookmotel]

Or maybe not... conformance is failing. I'll look into it.

[overlookmotel]

Well it seems I was wrong and adding __self in these cases is the correct behavior. I guess this at top level will refer to window in browser scripts, and undefined in ESM.

@Dunqing Well my review of #3258 wasn't my finest hour! I seem to have repeatedly got things wrong over and over again. Sorry for all the faffing around and time-wasting.