Skip to content

feat(transform): oxc_traverse crate#3169

Merged
Boshen merged 2 commits intomainfrom
05-05-feat_transform_oxc_traverse_crate
May 6, 2024
Merged

feat(transform): oxc_traverse crate#3169
Boshen merged 2 commits intomainfrom
05-05-feat_transform_oxc_traverse_crate

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 5, 2024

First part of #3152.

This adds a crate oxc_traverse, but doesn't connect it up to the transformer or anything else yet.

I think we could merge this now - as it doesn't affect any code that's in use - and then iterate on it to add scopes before using it in transformer. Please see #3152 (comment) for the broader picture.

@github-actions github-actions bot added the A-ast Area - AST label May 5, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented May 5, 2024

CodSpeed Performance Report

Merging #3169 will not alter performance

Comparing 05-05-feat_transform_oxc_traverse_crate (059d886) with main (f88f330)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen merged commit be87ca8 into main May 6, 2024
@Boshen Boshen deleted the 05-05-feat_transform_oxc_traverse_crate branch May 6, 2024 01:37
@@ -0,0 +1,149 @@
//! AST traversal with ability to read up the tree from visitors.
//!
//! Please see [`traverse_mut`] for an explanation of API.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These documents explain things really really good! I should read your PRs one by one, they are all treasures.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's incredibly kind of you to say. Thank you.

I do think it's important to write lengthy comments to explain how things work. But I'm a native English speaker, so I have an advantage in that respect - it's quite easy for me to turn thoughts into English words.

If you find anything where the comments don't make sense, or don't fully explain what the code is doing, or why, please do alert me and I'll do my best to improve them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants