Skip to content

docs: Update CONTRIBUTING.md#288

Merged
Boshen merged 1 commit intooxc-project:mainfrom
ild0tt0re:patch-1
Apr 17, 2023
Merged

docs: Update CONTRIBUTING.md#288
Boshen merged 1 commit intooxc-project:mainfrom
ild0tt0re:patch-1

Conversation

@ild0tt0re
Copy link
Contributor

Makes clear which project submodules will be installed and explicit move step before rustup show command

Makes clear which project submodules will be installed and explicit move step before rustup show command
@Boshen Boshen merged commit 53cf1f5 into oxc-project:main Apr 17, 2023
@Boshen
Copy link
Member

Boshen commented Apr 17, 2023

Thank you, and welcome!

graphite-app bot pushed a commit that referenced this pull request Feb 4, 2026
…18923)

## Summary

- Disable mimalloc as the global allocator on Windows for all NAPI packages (`oxc-parser`, `oxc-minify`, `oxc-transform`)
- On Windows, packages now use the system allocator instead

Fixes #15518

## Root Cause

mimalloc has known issues with DLL unloading on Windows when the DLL is loaded by the main thread but unloaded by a worker thread ([mimalloc issue #288](microsoft/mimalloc#288)). The cleanup code has `_mi_is_main_thread()` checks that prevent proper memory cleanup when called from a non-main thread, causing `STATUS_ACCESS_VIOLATION` crashes.

## Platforms with mimalloc enabled

| Platform | mimalloc |
|----------|----------|
| macOS | ✅ |
| Linux x86_64 | ✅ |
| Linux aarch64 | ✅ |
| Windows | ❌ (disabled) |
| FreeBSD | ❌ |
| ARM 32-bit | ❌ |
| WASM | ❌ |

🤖 Generated with [Claude Code](https://claude.ai/code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants