feat(linter): no constant condition#271
Merged
Boshen merged 6 commits intooxc-project:mainfrom Apr 9, 2023
mysteryven:feat/eslint-no-constant-condition
Merged
feat(linter): no constant condition#271Boshen merged 6 commits intooxc-project:mainfrom mysteryven:feat/eslint-no-constant-condition
Boshen merged 6 commits intooxc-project:mainfrom
mysteryven:feat/eslint-no-constant-condition
Conversation
Boshen
reviewed
Apr 9, 2023
Boshen
reviewed
Apr 9, 2023
Member
|
Thank you! We'll implement the rest when we have CFG. |
camc314
pushed a commit
that referenced
this pull request
May 13, 2025
…no_constant_condition` (#10949) Followup to #271 - implemented configuration correctly (supports boolean or choosing one of three enum variants) - implemented checking while, do-while and for loops - re-imported tests from eslint and re-ordered them to reduce git diff - updated rule docs to recommended format - added explanation of new configuration option to rule docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: #258