Skip to content

refactor(allocator): fix lifetimes clippy warnings #21210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Apr 9, 2026
+3 −5
Merged

refactor(allocator): fix lifetimes clippy warnings #21210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions crates/oxc_allocator/src/bump.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
clippy::borrow_as_ptr,
clippy::cast_ptr_alignment,
clippy::cast_sign_loss,
clippy::elidable_lifetime_names,
clippy::filter_map_next,
clippy::inconsistent_struct_constructor,
clippy::inline_always,
Expand All @@ -16,7 +15,6 @@
clippy::missing_errors_doc,
clippy::missing_panics_doc,
clippy::mut_from_ref,
clippy::needless_lifetimes,
clippy::ptr_as_ptr,
clippy::ptr_cast_constness,
clippy::ref_as_ptr,
Expand Down Expand Up @@ -2456,7 +2454,7 @@ impl<'a, const MIN_ALIGN: usize> Iterator for ChunkIter<'a, MIN_ALIGN> {
}
}

impl<'a, const MIN_ALIGN: usize> iter::FusedIterator for ChunkIter<'a, MIN_ALIGN> {}
impl<const MIN_ALIGN: usize> iter::FusedIterator for ChunkIter<'_, MIN_ALIGN> {}

/// An iterator over raw pointers to chunks of allocated memory that this
/// arena has bump allocated into.
Expand Down Expand Up @@ -2498,7 +2496,7 @@ fn oom() -> ! {
panic!("out of memory")
}

unsafe impl<'a, const MIN_ALIGN: usize> bumpalo_alloc::Alloc for &'a Bump<MIN_ALIGN> {
unsafe impl<const MIN_ALIGN: usize> bumpalo_alloc::Alloc for &Bump<MIN_ALIGN> {
#[inline(always)]
unsafe fn alloc(&mut self, layout: Layout) -> Result<NonNull<u8>, AllocErr> {
self.try_alloc_layout(layout)
Expand Down Expand Up @@ -2542,7 +2540,7 @@ unsafe impl<'a, const MIN_ALIGN: usize> bumpalo_alloc::Alloc for &'a Bump<MIN_AL
#[cfg(doctest)]
fn _doctest_only() {}

unsafe impl<'a, const MIN_ALIGN: usize> Allocator for &'a Bump<MIN_ALIGN> {
unsafe impl<const MIN_ALIGN: usize> Allocator for &Bump<MIN_ALIGN> {
#[inline]
fn allocate(&self, layout: Layout) -> Result<NonNull<[u8]>, AllocError> {
self.try_alloc_layout(layout)
Expand Down
Loading