perf(napi/parser): deserializing tokens use only `int32` array by overlookmotel · Pull Request #21138 · oxc-project/oxc

overlookmotel · 2026-04-07T15:41:14Z

Small perf optimization. When deserializing tokens in oxc-parser, use only the Int32Array view of the buffer, instead of both Int32Array and Uint8Array. Less values to keep in registers, and int32 doesn't need to be obtained with a property lookup on each call.

overlookmotel · 2026-04-07T15:41:43Z

perf(napi/parser, linter/plugins): raw transfer deserializer for Vecs use shift instead of multiply where possible #21142
perf(napi/parser, linter/plugins): shift before add when calculating positions in raw transfer deserializer #21141
perf(napi/parser, linter/plugins): remove uint32 buffer view #21140
perf(napi/parser): lazy deserialization use only Int32Array #21139
perf(napi/parser): deserializing tokens use only int32 array #21138 👈 (View in Graphite)
perf(parser): tokens raw deserialization use Int32Array #21137
perf(linter/plugins): use Int32Arrays for tokens and comments buffers #21136
perf(napi/parser, linter/plugins): raw transfer deserialize Span fields as i32s #21135
perf(napi/parser, linter/plugins): inline trivial raw transfer field deserializers into node object definitions #21134
feat(ast_tools): support inlining custom deserialized fields with #[estree(raw_deser_inline)] #21133
perf(napi/parser, linter/plugins): use Int32Array in raw transfer deserializer #21132
refactor(napi/parser, linter/plugins): add int32 buffer view #21131
docs(linter/plugins): correct comments #21130
perf(linter/plugins): use >> not >>> in binary search loops #21129
test(napi/parser): fix benchmarks #21128
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

Optimizes raw-transfer token deserialization in napi/parser by relying on a single Int32Array view for token reads, reducing per-token property lookups and avoiding mixed typed-array access patterns.

Changes:

Pass the precomputed Int32Array view into deserializeToken instead of re-reading it from buffer each call.
Pack token kind/flags reads into a single int32 load (kindAndFlags) and derive kind / is_escaped from it.

napi/parser/src-js/raw-transfer/eager.js

graphite-app · 2026-04-07T17:29:48Z

Merge activity

Apr 7, 5:29 PM UTC: graphite-app added this pull request to the Graphite merge queue.
Apr 7, 5:43 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #21136.
Apr 7, 5:43 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #21136.
Apr 7, 11:03 PM UTC: The merge label '0-merge' was removed. This PR will no longer be merged by the Graphite merge queue
Apr 7, 11:04 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Apr 7, 11:09 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
Apr 7, 11:20 PM UTC: Merged by the Graphite merge queue.

Small perf optimization. When deserializing tokens in `oxc-parser`, use only the `Int32Array` view of the buffer, instead of both `Int32Array` and `Uint8Array`. Less values to keep in registers, and `int32` doesn't need to be obtained with a property lookup on each call.

### 💥 BREAKING CHANGES - 36cdc31 str: [**BREAKING**] Remove identity `FromIn` impl for `Ident` (#21251) (overlookmotel) - 382958a span: [**BREAKING**] Remove re-exports of string types from `oxc_span` crate (#21246) (overlookmotel) - c4aedfa str: [**BREAKING**] Add `static_ident!` macro (#21245) (overlookmotel) ### 🚀 Features - e7e1aea transformer/typescript: Add `optimize_enums` option for regular enum inlining (#20539) (Dunqing) - 679f57f transformer/typescript: Implement const enum inlining and declaration removal (#20508) (Dunqing) - 6dd061c semantic: Extend `MemberWriteTarget` to cover all property modification patterns (#21205) (Dunqing) - f134e24 minifier: Support `property_write_side_effects` option to drop unused property assignments (#20773) (Dunqing) - 75663c0 semantic: Add enum member value evaluation for const enum support (#20602) (Dunqing) - 3cfe8ed semantic: Add `MemberWriteTarget` flag to `ReferenceFlags` (#20772) (Dunqing) ### 🐛 Bug Fixes - af1a586 transformer/class-properties: Use correct property name when converting parameter properties (#21268) (Amal Jossy) - b43250a allocator: Move allocation tracking into `Bump` (#21342) (overlookmotel) - 36f505f allocator: `StringBuilder` use `Allocator::alloc_layout` (#21340) (overlookmotel) - 7a08a6f allocator: Fix allocation counting in `Allocator::alloc_concat_strs_array` (#21336) (overlookmotel) - 2338e28 ecmascript: Treat `this` as potentially having side effects (#21297) (sapphi-red) - bd8bd39 allocator: Remove unsafe hacks from `from_raw_parts` methods (#21283) (overlookmotel) - 8f4c340 allocator: Remove dangerous pointer const to mut cast (#21279) (overlookmotel) - aa9259f parser: Add missing error code for optional param diagnostic (#21258) (camc314) - 04b3c2f str: Fix unsound casting const pointers to mut pointers (#21242) (overlookmotel) - ceadf6c str: Make `Ident::from_raw` an unsafe function (#21241) (overlookmotel) - eab13b3 transformer/decorators: Avoid accessor storage name collisions (#21106) (Dunqing) - 07e8a30 transformer/react-refresh: Handle parenthesized variable initializers (#21047) (camc314) ### ⚡ Performance - c3ca6f6 allocator: `StringBuilder::from_strs_array_in` check for 0 length earlier (#21338) (overlookmotel) - c2422bb allocator: `Allocator::alloc_concat_strs_array` check for 0 length earlier (#21337) (overlookmotel) - 04b0fdc allocator: Mark `Allocator::alloc_layout` as `#[inline(always)]` (#21335) (overlookmotel) - 17aee9e allocator: Use `offset_from_unsigned` in `ChunkFooter::as_raw_parts` (#21280) (overlookmotel) - 61adedd minifier: Fix O(n²) perf on very many var decls (#21062) (Gunnlaugur Thor Briem) - addcd02 napi/parser, linter/plugins: Raw transfer deserializer for `Vec`s use shift instead of multiply where possible (#21142) (overlookmotel) - 3068ded napi/parser, linter/plugins: Shift before add when calculating positions in raw transfer deserializer (#21141) (overlookmotel) - eb400b8 napi/parser, linter/plugins: Remove `uint32` buffer view (#21140) (overlookmotel) - 2675085 napi/parser: Lazy deserialization use only `Int32Array` (#21139) (overlookmotel) - 5b35a53 napi/parser: Deserializing tokens use only `int32` array (#21138) (overlookmotel) - f163d10 parser: Tokens raw deserialization use `Int32Array` (#21137) (overlookmotel) - 7a86613 linter/plugins: Use `Int32Array`s for tokens and comments buffers (#21136) (overlookmotel) - 8c51121 napi/parser, linter/plugins: Raw transfer deserialize `Span` fields as `i32`s (#21135) (overlookmotel) - bc1bcdd napi/parser, linter/plugins: Inline trivial raw transfer field deserializers into node object definitions (#21134) (overlookmotel) - c0278ab napi/parser, linter/plugins: Use `Int32Array` in raw transfer deserializer (#21132) (overlookmotel) - 43482c7 linter/plugins: Use `>>` not `>>>` in binary search loops (#21129) (overlookmotel) ### 📚 Documentation - f5e1845 allocator: Upgrade headers in doc comments for `Bump` (#21263) (overlookmotel) - 2870174 allocator: Upper case `SAFETY` in comments (#21253) (overlookmotel) - 01bc269 str: Reformat `Ident` doc comments (#21240) (overlookmotel) - dd47359 allocator: Add doc comments for panics and errors (#21230) (overlookmotel)

overlookmotel mentioned this pull request Apr 7, 2026

perf(parser): tokens raw deserialization use Int32Array #21137

Merged

github-actions bot added the A-parser Area - Parser label Apr 7, 2026

overlookmotel mentioned this pull request Apr 7, 2026

perf(napi/parser): lazy deserialization use only Int32Array #21139

Merged

github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Apr 7, 2026

overlookmotel marked this pull request as ready for review April 7, 2026 16:31

Copilot AI review requested due to automatic review settings April 7, 2026 16:31

Copilot started reviewing on behalf of overlookmotel April 7, 2026 16:32 View session

Copilot AI reviewed Apr 7, 2026

View reviewed changes

napi/parser/src-js/raw-transfer/eager.js Outdated Show resolved Hide resolved

overlookmotel force-pushed the om/04-07-perf_parser_tokens_raw_deserialization_use_int32array_ branch from 9de5b58 to e57c5c6 Compare April 7, 2026 16:39

overlookmotel force-pushed the om/04-07-perf_napi_parser_deserializing_tokens_use_only_int32_array branch from 43fd2d8 to 0493ecf Compare April 7, 2026 16:39

overlookmotel self-assigned this Apr 7, 2026

overlookmotel force-pushed the om/04-07-perf_napi_parser_deserializing_tokens_use_only_int32_array branch from 0493ecf to e9db279 Compare April 7, 2026 16:51

graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Apr 7, 2026

graphite-app bot force-pushed the om/04-07-perf_parser_tokens_raw_deserialization_use_int32array_ branch from e57c5c6 to bf69e35 Compare April 7, 2026 17:20

graphite-app bot requested a review from camc314 as a code owner April 7, 2026 17:20

graphite-app bot force-pushed the om/04-07-perf_napi_parser_deserializing_tokens_use_only_int32_array branch from e9db279 to 75fa7e7 Compare April 7, 2026 17:21

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 7, 2026

overlookmotel force-pushed the om/04-07-perf_parser_tokens_raw_deserialization_use_int32array_ branch from bf69e35 to 20389f1 Compare April 7, 2026 23:03

overlookmotel force-pushed the om/04-07-perf_napi_parser_deserializing_tokens_use_only_int32_array branch from 75fa7e7 to 8f0a9fe Compare April 7, 2026 23:03

overlookmotel added the 0-merge Merge with Graphite Merge Queue label Apr 7, 2026 — with Graphite App

graphite-app bot force-pushed the om/04-07-perf_parser_tokens_raw_deserialization_use_int32array_ branch from 20389f1 to f163d10 Compare April 7, 2026 23:14

graphite-app bot force-pushed the om/04-07-perf_napi_parser_deserializing_tokens_use_only_int32_array branch from 8f0a9fe to 5b35a53 Compare April 7, 2026 23:15

Base automatically changed from om/04-07-perf_parser_tokens_raw_deserialization_use_int32array_ to main April 7, 2026 23:18

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 7, 2026

graphite-app bot merged commit 5b35a53 into main Apr 7, 2026
24 of 25 checks passed

graphite-app bot deleted the om/04-07-perf_napi_parser_deserializing_tokens_use_only_int32_array branch April 7, 2026 23:20

Boshen mentioned this pull request Apr 13, 2026

release(crates): oxc v0.125.0 #21374

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

perf(napi/parser): deserializing tokens use only `int32` array#21138

perf(napi/parser): deserializing tokens use only `int32` array#21138
graphite-app[bot] merged 1 commit intomainfrom
om/04-07-perf_napi_parser_deserializing_tokens_use_only_int32_array

overlookmotel commented Apr 7, 2026 •

edited

Loading

Uh oh!

overlookmotel commented Apr 7, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

graphite-app bot commented Apr 7, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

overlookmotel commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

graphite-app bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

overlookmotel commented Apr 7, 2026 •

edited

Loading

overlookmotel commented Apr 7, 2026 •

edited

Loading

graphite-app bot commented Apr 7, 2026 •

edited

Loading