fix(linter/no-array-index-key): false positive when index is inside an expression within a template literal#21123
Merged
camc314 merged 2 commits intooxc-project:mainfrom Apr 7, 2026
Conversation
…n expression within a template literal
Merging this PR will not alter performance
Comparing Footnotes
|
camc314
requested changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21110
Related: #21012
Summary
The
TemplateLiteralbranch inexpression_uses_indexwas callingexpression_uses_indexrecursively, so it detected index even when wrapped in a binary expression or function call inside${...}. ESLint only checks for direct index references, so replaced withis_index_reference.ESLint comparison (inside template literals)
`abc${index}``${item.type + index}``abc${String(index)}``abc${index.toString()}`