Skip to content

fix(linter/unicorn): do not report on optionals in prefer-array-flat-map #21082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camc314 merged 1 commit into from
Apr 6, 2026
Merged

fix(linter/unicorn): do not report on optionals in prefer-array-flat-map #21082

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions crates/oxc_linter/src/rules/unicorn/prefer_array_flat_map.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ impl Rule for PreferArrayFlatMap {
return;
};

if flat_call_expr.optional {
return;
}

if flat_call_expr.arguments.len() > 1 {
return;
}
Expand All @@ -62,10 +66,20 @@ impl Rule for PreferArrayFlatMap {
let Some(member_expr) = flat_call_expr.callee.as_member_expression() else {
return;
};

if member_expr.optional() {
return;
}

let Expression::CallExpression(call_expr) = &member_expr.object().without_parentheses()
else {
return;
};

if call_expr.optional {
return;
}

if !is_method_call(call_expr, None, Some(&["map"]), None, None) {
return;
}
Expand Down Expand Up @@ -128,10 +142,9 @@ fn test() {
"const bar = [1,2,3].map((i) => i)",
"const bar = [1,2,3].map((i) => { return i; })",
"const bar = foo.map(i => i)",
// TODO: Fix the rule so these tests pass.
// "const bar = foo.map?.(i => [i]).flat()",
// "const bar = foo.map(i => [i])?.flat()",
// "const bar = foo.map(i => [i]).flat?.()",
"const bar = foo.map?.(i => [i]).flat()",
"const bar = foo.map(i => [i])?.flat()",
"const bar = foo.map(i => [i]).flat?.()",
"const bar = [[1],[2],[3]].flat()",
"const bar = [1,2,3].map(i => [i]).sort().flat()",
"let bar = [1,2,3].map(i => [i]);
Expand Down
Loading