fix(oxlint/lsp): remove uri cache on document change#21039
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 5, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-editor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the oxlint language server to clear per-URI tool caches when a document changes, ensuring code actions aren’t generated from stale cached state when editors request textDocument/codeAction without refreshing diagnostics first.
Changes:
- Clear the tool’s per-URI cache on
textDocument/didChangeviaworker.remove_uri_cache(&uri). - Add an explanatory comment describing why the cache clear is needed for some client behaviors.
Sysix
force-pushed
the
04-04-fix_oxlint_lsp_remove_uri_cache_on_document_change
branch
from
7cc919d to
37c5e43
Compare
Sysix
force-pushed
the
04-04-fix_oxlint_lsp_remove_uri_cache_on_document_change
branch
from
37c5e43 to
33c5b05
Compare
camc314
approved these changes
Apr 5, 2026
Contributor
Merge activity
|
graphite-app
bot
force-pushed
the
04-04-fix_oxlint_lsp_remove_uri_cache_on_document_change
branch
from
33c5b05 to
1550561
Compare
graphite-app
bot
deleted the
04-04-fix_oxlint_lsp_remove_uri_cache_on_document_change
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does not fix the stale diagnostics, but we now have at least a clean state on the linter side, when the document changed, but code actions are requested without a diagnostic request before.
Was originally found by #19793 and moved into an own PR for here.
Thank you, @wagenet