Skip to content

refactor(oxfmt): Use Copy for OutputMode enum #20998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Apr 3, 2026
+2 −3
Merged

refactor(oxfmt): Use Copy for OutputMode enum #20998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/oxfmt/src/cli/command.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ fn mode() -> impl bpaf::Parser<Mode> {
}

/// Format output mode
#[derive(Debug, Clone)]
#[derive(Debug, Clone, Copy)]
pub enum OutputMode {
/// Default - when no output option is specified, behaves like `--write` mode in Prettier
Write,
Expand Down
3 changes: 1 addition & 2 deletions apps/oxfmt/src/cli/format.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,12 +172,11 @@ impl CliRunner {
let source_formatter = source_formatter.with_external_formatter(self.external_formatter);

let no_config = config_resolver.config_dir().is_none() && editorconfig_path.is_none();
let format_mode_clone = format_mode.clone();

// Spawn a thread to run formatting service with streaming entries
rayon::spawn(move || {
let format_service =
FormatService::new(cwd, format_mode_clone, source_formatter, config_resolver);
FormatService::new(cwd, format_mode, source_formatter, config_resolver);
format_service.run_streaming(rx_entry, &tx_error, &tx_success);
});

Expand Down
Loading