Skip to content

test(allocator): fix test on 32 bit platforms#20977

Merged
overlookmotel merged 1 commit intomainfrom
om/04-02-test_allocator_fix_test_on_32_bit_platforms
Apr 2, 2026
Merged

test(allocator): fix test on 32 bit platforms#20977
overlookmotel merged 1 commit intomainfrom
om/04-02-test_allocator_fix_test_on_32_bit_platforms

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Apr 2, 2026

#20963 had a test failing on 32-bit platforms. Fix it.

Copy link
Copy Markdown
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Apr 2, 2026
@overlookmotel overlookmotel marked this pull request as ready for review April 2, 2026 16:44
Copilot AI review requested due to automatic review settings April 2, 2026 16:44
@overlookmotel overlookmotel self-assigned this Apr 2, 2026
@overlookmotel overlookmotel added the A-allocator Area - Allocator label Apr 2, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an allocator unit test that was failing on 32-bit targets by making the ChunkFooter size assertion architecture-aware, aligning the test with the actual ChunkFooter layout/padding on different pointer widths.

Changes:

  • Split ChunkFooter size assertion into two #[cfg(target_pointer_width = "...")] tests.
  • Updated test names to reflect the expected word counts on 64-bit vs 32-bit platforms.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 2, 2026

Merging this PR will not alter performance

✅ 48 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing om/04-02-test_allocator_fix_test_on_32_bit_platforms (35367a0) with main (c1a48f0)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@overlookmotel overlookmotel merged commit 6323459 into main Apr 2, 2026
40 checks passed
@overlookmotel overlookmotel deleted the om/04-02-test_allocator_fix_test_on_32_bit_platforms branch April 2, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-allocator Area - Allocator C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants