refactor(ast): simplify ESTree serialization of Ident

[overlookmotel]

Ident is always JSON-safe (cannot contain characters which require escaping in JSON). Remove #[estree(json_safe)] from fields containing Ident, and apply the JSON-safe optimization as part of Ident's ESTree impl.

This also fixes one Ident we'd missed flagging as JSON-safe previously - the Ident in PrivateIdentifier - which will be a small perf boost.

[overlookmotel]

• refactor(ast): simplify ESTree serialization of Ident #20932 👈 (View in Graphite)
• fix(ast_tools): correct error message and doc comment #20930
• refactor(napi/parser, linter/plugins): shorten raw transfer deserializers for Options #20924
• perf(napi/parser, linter/plugins): faster deserialization of raw fields #20923
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

Merging this PR will not alter performance

✅ 48 untouched benchmarks
⏩ 8 skipped benchmarks¹

---

_{Comparing om/04-01-refactor_ast_simplify_estree_serialization_of_ident_ (a04f405) with main (f9ef1bd)²}

Footnotes

1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

2. No successful run was found on main (2a28e4c) during the generation of this report, so f9ef1bd was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[Copilot]

Pull request overview

Refactors ESTree serialization to treat Ident as JSON-safe at the type level, removing per-field #[estree(json_safe)] annotations and relying on Ident’s ESTree impl for the optimization.

Changes:

• Update Ident’s ESTree implementation to serialize via JsonSafeString.
• Remove #[estree(json_safe)] from Ident fields in JS identifier AST node types.
• Update generated ESTree serializers to serialize identifier name fields via Ident directly (instead of wrapping as_str() in JsonSafeString at call sites).

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File	Description
crates/oxc_str/src/ident.rs	Moves JSON-safe serialization optimization into Ident’s ESTree impl via JsonSafeString.
crates/oxc_ast/src/generated/derive_estree.rs	Switches identifier name field serialization to &self.name (delegating to Ident’s ESTree).
crates/oxc_ast/src/ast/js.rs	Removes #[estree(json_safe)] from Ident-typed name fields now that Ident handles it.

[graphite-app]

Merge activity

• Apr 1, 12:05 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
• Apr 1, 12:18 PM UTC: Merged by the Graphite merge queue.