Skip to content

fix(formatter): Use hard_space for as_or_satisfies#20859

Closed
leaysgur wants to merge 1 commit into03-30-fix_formatter_place_decorator_on_own_line_with_long_propertyfrom
03-30-fix_formatter_use_hard_space_for_as_or_satisfies
Closed

fix(formatter): Use hard_space for as_or_satisfies#20859
leaysgur wants to merge 1 commit into03-30-fix_formatter_place_decorator_on_own_line_with_long_propertyfrom
03-30-fix_formatter_use_hard_space_for_as_or_satisfies

Conversation

@leaysgur
Copy link
Copy Markdown
Member

@leaysgur leaysgur commented Mar 30, 2026

The same as #20858, but for as and satisfies.

Theoretically, there may be other cases where this has an impact, but I haven't been able to find any existing tests that demonstrate it.

@leaysgur leaysgur requested a review from Dunqing as a code owner March 30, 2026 07:20
Copy link
Copy Markdown
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-formatter Area - Formatter C-bug Category - Bug labels Mar 30, 2026
@leaysgur leaysgur changed the title fix(formatter): Use hard_space for as_or_satisfies fix(formatter): Use hard_space for as_or_satisfies Mar 30, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 30, 2026

Merging this PR will not alter performance

✅ 44 untouched benchmarks
⏩ 12 skipped benchmarks1


Comparing 03-30-fix_formatter_use_hard_space_for_as_or_satisfies (0a84847) with 03-30-fix_formatter_place_decorator_on_own_line_with_long_property (02ca7b3)

Open in CodSpeed

Footnotes

  1. 12 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Dunqing
Dunqing previously approved these changes Apr 1, 2026
@Dunqing
Copy link
Copy Markdown
Member

Dunqing commented Apr 1, 2026

I just remembered this is a upstream bug, see prettier/prettier#18148

@leaysgur leaysgur closed this Apr 2, 2026
@leaysgur leaysgur deleted the 03-30-fix_formatter_use_hard_space_for_as_or_satisfies branch April 2, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants