Skip to content

docs(ast): correct comment#20837

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/03-29-docs_ast_correct_comment
Mar 29, 2026
Merged

docs(ast): correct comment#20837
graphite-app[bot] merged 1 commit intomainfrom
om/03-29-docs_ast_correct_comment

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Mar 29, 2026

format_atom! takes allocator as first param. Correct a doc comment to show the correct usage.

Copy link
Copy Markdown
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-ast Area - AST C-docs Category - Documentation. Related to user-facing or internal documentation labels Mar 29, 2026
@overlookmotel overlookmotel marked this pull request as ready for review March 29, 2026 12:36
Copilot AI review requested due to automatic review settings March 29, 2026 12:36
@overlookmotel overlookmotel self-assigned this Mar 29, 2026
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Mar 29, 2026
Copy link
Copy Markdown
Member Author

overlookmotel commented Mar 29, 2026

Merge activity

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates an AST doc comment to reflect the correct format_atom! macro call signature (allocator as the first argument), improving guidance for keeping RegExpPattern.text in sync with its parsed pattern.

Changes:

  • Fixes the example usage of format_atom! in the RegExpPattern documentation comment to pass the allocator first.

`format_atom!` takes allocator as first param. Correct a doc comment to show the correct usage.
@graphite-app graphite-app bot force-pushed the om/03-29-docs_ast_correct_comment branch from 088d720 to 868448e Compare March 29, 2026 12:40
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 29, 2026

Merging this PR will degrade performance by 3.27%

❌ 1 regressed benchmark
✅ 43 untouched benchmarks
⏩ 12 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation mangler[RadixUIAdoptionSection.jsx_keep_names] 19.4 µs 20.1 µs -3.27%

Comparing om/03-29-docs_ast_correct_comment (088d720) with main (ae03653)2

Open in CodSpeed

Footnotes

  1. 12 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (a147878) during the generation of this report, so ae03653 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@graphite-app graphite-app bot merged commit 868448e into main Mar 29, 2026
26 checks passed
@graphite-app graphite-app bot deleted the om/03-29-docs_ast_correct_comment branch March 29, 2026 12:43
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants