Skip to content

fix(minifier): inline single-use vars past non-computed object keys#20810

Merged
Boshen merged 1 commit intooxc-project:mainfrom
ulrichstark:fix(minifier)--inline-single-use-vars-past-non-computed-object-keys
Mar 28, 2026
Merged

fix(minifier): inline single-use vars past non-computed object keys#20810
Boshen merged 1 commit intooxc-project:mainfrom
ulrichstark:fix(minifier)--inline-single-use-vars-past-non-computed-object-keys

Conversation

@ulrichstark
Copy link
Copy Markdown
Contributor

Fixes #20802

This fixes a bug in single-use variable inlining where object literals with non-computed string keys like "-a" were incorrectly treated like computed properties and stopped further substitution.

@github-actions github-actions bot added A-minifier Area - Minifier C-bug Category - Bug labels Mar 27, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 27, 2026

Merging this PR will not alter performance

✅ 44 untouched benchmarks
⏩ 12 skipped benchmarks1


Comparing ulrichstark:fix(minifier)--inline-single-use-vars-past-non-computed-object-keys (c333546) with main (6624513)2

Open in CodSpeed

Footnotes

  1. 12 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (6171217) during the generation of this report, so 6624513 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Boshen Boshen merged commit 1a370a6 into oxc-project:main Mar 28, 2026
33 checks passed
@ulrichstark ulrichstark deleted the fix(minifier)--inline-single-use-vars-past-non-computed-object-keys branch March 28, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

minifier: inlining variables in object when string key is encountered

2 participants