Skip to content

refactor(parser): remove dead code from modifier parsing #20735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Mar 25, 2026
+1 −13
Merged

refactor(parser): remove dead code from modifier parsing #20735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions crates/oxc_parser/src/modifiers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,7 @@ use oxc_ast::ast::TSAccessibility;
use oxc_diagnostics::OxcDiagnostic;
use oxc_span::Span;

use crate::{
ParserConfig as Config, ParserImpl, diagnostics,
lexer::{Kind, Token},
};
use crate::{ParserConfig as Config, ParserImpl, diagnostics, lexer::Kind};

bitflags! {
/// Bitflag of modifiers and contextual modifiers.
Expand All @@ -33,7 +30,6 @@ bitflags! {
const ACCESSOR = 1 << 14;
const EXPORT = 1 << 15;
const ACCESSIBILITY = Self::PRIVATE.bits() | Self::PROTECTED.bits() | Self::PUBLIC.bits();
const TYPE_PARAM = Self::CONST.bits() | Self::IN.bits() | Self::OUT.bits();
}
}

Expand Down Expand Up @@ -130,14 +126,6 @@ impl Modifier {
}
}

impl TryFrom<Token> for Modifier {
type Error = <ModifierKind as TryFrom<Kind>>::Error;

fn try_from(tok: Token) -> Result<Self, Self::Error> {
ModifierKind::try_from(tok.kind()).map(|kind| Self { span: tok.span(), kind })
}
}

/// Symbol modifiers. Primarily used in TypeScript code, but some are also used
/// in JavaScript.
///
Expand Down
Loading