Skip to content

fix(codegen): preserve coverage comments before ConditionalExpression alternate and between SwitchCases#20718

Merged
graphite-app[bot] merged 1 commit intomainfrom
fix/codegen-preserve-coverage-comments
Mar 25, 2026
Merged

fix(codegen): preserve coverage comments before ConditionalExpression alternate and between SwitchCases#20718
graphite-app[bot] merged 1 commit intomainfrom
fix/codegen-preserve-coverage-comments

Conversation

@Boshen
Copy link
Copy Markdown
Member

@Boshen Boshen commented Mar 24, 2026

Summary

  • Print leading coverage ignore comments (e.g. /* istanbul ignore next */) before ConditionalExpression's alternate expression
  • Print leading coverage ignore comments before case/default keywords in SwitchStatement

Closes #20549

🤖 Generated with Claude Code

@github-actions github-actions bot added A-codegen Area - Code Generation C-bug Category - Bug labels Mar 24, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 24, 2026

Merging this PR will not alter performance

✅ 53 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing fix/codegen-preserve-coverage-comments (c6a5b0a) with main (c09a5ab)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Boshen Boshen force-pushed the fix/codegen-preserve-coverage-comments branch from 8b6d75e to 2afd35c Compare March 24, 2026 23:38
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8b6d75e010

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Boshen Boshen force-pushed the fix/codegen-preserve-coverage-comments branch 2 times, most recently from 302dfae to c6a5b0a Compare March 24, 2026 23:59
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Mar 25, 2026
Copy link
Copy Markdown
Member Author

Boshen commented Mar 25, 2026

Merge activity

…n` alternate and between `SwitchCase`s (#20718)

## Summary

- Print leading coverage ignore comments (e.g. `/* istanbul ignore next */`) before `ConditionalExpression`'s alternate expression
- Print leading coverage ignore comments before `case`/`default` keywords in `SwitchStatement`

Closes #20549

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@graphite-app graphite-app bot force-pushed the fix/codegen-preserve-coverage-comments branch from c6a5b0a to 77abf54 Compare March 25, 2026 00:07
@graphite-app graphite-app bot merged commit 77abf54 into main Mar 25, 2026
26 checks passed
@graphite-app graphite-app bot deleted the fix/codegen-preserve-coverage-comments branch March 25, 2026 00:11
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-codegen Area - Code Generation C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

codegen: preserve coverage comments before ConditionalExpression's alternate and between SwitchStatement's cases

1 participant