Skip to content

perf(allocator): remove op from StringBuilder::grow_one #20650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Mar 23, 2026
+4 −3
Merged

perf(allocator): remove op from StringBuilder::grow_one #20650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions crates/oxc_allocator/src/string_builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,9 +524,10 @@ impl<'a> StringBuilder<'a> {
// `DEFAULT_MIN_CAPACITY` in `with_capacity_in` and `from_str_in`, then can remove this line.
let additional = cmp::max(current_capacity, DEFAULT_MIN_CAPACITY);

let new_capacity = current_capacity
.checked_add(additional)
.expect("attempt to grow `StringBuilder` beyond `isize::MAX` bytes");
// `current_capacity` is max `isize::MAX` bytes.
// `additional` is also max `isize::MAX` bytes.
// Therefore this addition cannot overflow.
let new_capacity = current_capacity + additional;

// SAFETY: We already allocated this, so must have a valid layout
let old_layout = unsafe { Layout::from_size_align_unchecked(current_capacity, 1) };
Expand Down
Loading