Skip to content

feat(linter): implement vitest/prefer-strict-boolean-matchers rule#20603

Merged
camc314 merged 1 commit intooxc-project:mainfrom
baevm:prefer-strict-boolean-matchers
Mar 21, 2026
Merged

feat(linter): implement vitest/prefer-strict-boolean-matchers rule#20603
camc314 merged 1 commit intooxc-project:mainfrom
baevm:prefer-strict-boolean-matchers

Conversation

@baevm
Copy link
Copy Markdown
Contributor

@baevm baevm commented Mar 21, 2026

This PR adds vitest/prefer-strict-boolean-matchers rule.
Passes all original tests with added extra tests for cases like this: expect(value)["toBeFalsy"]();

issue #4656

@baevm baevm requested a review from camc314 as a code owner March 21, 2026 13:43
@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Mar 21, 2026
@baevm
Copy link
Copy Markdown
Contributor Author

baevm commented Mar 21, 2026

@codex code review

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 21, 2026

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 52 skipped benchmarks1


Comparing baevm:prefer-strict-boolean-matchers (580d952) with main (9a622c7)2

Open in CodSpeed

Footnotes

  1. 52 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (532c921) during the generation of this report, so 9a622c7 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 580d952403

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@camc314 camc314 merged commit 2244984 into oxc-project:main Mar 21, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants