perf(ast): mark AstKind::address as #[inline]

[overlookmotel]

Similar to #20585. As AstKind's variants are all structs (no enums any more), and all structs have an AstKind, AstKind::address method boils down to a no-op. So mark it #[inline].

Also remove some defunct code from AstKind codegen which was handling when an AstKind refers to an enum. This circumstance is no longer possible, so remove this code.

[overlookmotel]

• refactor(ast_tools): simplify struct field reordering #20587
• perf(ast): mark AstKind::address as #[inline] #20586 👈 (View in Graphite)
• perf(ast): mark AstKind::span as #[inline] #20585
• perf(ast): place NodeId field after Span in structs #20584
• refactor(ast): re-order layout assertions in memory order #20583
• refactor(ast_tools): convert layout calculation to a struct with methods #20582
• fix(ast_tools): remove NonMax32 primitive #20581
• fix(ast_tools): correctly parse define_index_type! macros #20580
• perf(ast_tools): reduce data passing between functions #20579
• perf(ast_tools): parse files in parallel #20578
• refactor(ast_tools): search all crates which depend on oxc_ast_macros #20577
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

Merging this PR will not alter performance

✅ 53 untouched benchmarks
⏩ 3 skipped benchmarks¹

---

_{Comparing om/02-15-perf_ast_mark_astkind_address_as_inline_ (79deba6) with om/02-15-perf_ast_mark_astkind_span_as_inline_ (9eaf443)²}

Footnotes

1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

2. No successful run was found on om/02-15-perf_ast_mark_astkind_span_as_inline_ (c9edd39) during the generation of this report, so 00ee51b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[Copilot]

Pull request overview

Marks AstKind::address as #[inline] and simplifies AstKind codegen based on the invariant that AstKind variants only wrap structs (not enums), keeping address retrieval essentially a no-op/pointer read.

Changes:

• Add #[inline] to GetAddress for AstKind::address (both generator + generated output).
• Remove defunct enum-handling branches in AstKind generator when building has_kind/address match arms.
• Add brief documentation clarifying why AstKind::address is a single-instruction operation.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File	Description
tasks/ast_tools/src/generators/ast_kind.rs	Simplifies address match-arm generation and annotates AstKind::address with #[inline] + docs.
crates/oxc_ast/src/generated/ast_kind.rs	Regenerates AstKind output with the new #[inline] + docs on address().

[graphite-app]

Merge activity

• Mar 20, 10:15 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
• Mar 20, 10:31 PM UTC: Merged by the Graphite merge queue.