Skip to content

perf(napi/parser, oxlint/plugins): shorten deserializer for WithClause #20575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Mar 20, 2026
Merged

perf(napi/parser, oxlint/plugins): shorten deserializer for WithClause #20575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions apps/oxlint/src-js/generated/deserialize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2937,14 +2937,7 @@ function deserializeImportNamespaceSpecifier(pos) {
}

function deserializeWithClause(pos) {
let start, end;
return {
__proto__: NodeProto,
attributes: deserializeVecImportAttribute(pos + 8),
start: (start = deserializeU32(pos)),
end: (end = deserializeU32(pos + 4)),
range: [start, end],
};
return { attributes: deserializeVecImportAttribute(pos + 8) };
}

function deserializeImportAttribute(pos) {
Expand Down
1 change: 1 addition & 0 deletions crates/oxc_ast/src/ast/js.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2638,6 +2638,7 @@ pub struct ImportNamespaceSpecifier<'a> {
#[estree(no_type, no_ts_def)]
pub struct WithClause<'a> {
pub node_id: Cell<NodeId>,
#[estree(skip)]
pub span: Span,
#[estree(skip)]
pub keyword: WithClauseKeyword,
Expand Down
1 change: 0 additions & 1 deletion crates/oxc_ast/src/generated/derive_estree.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1638,7 +1638,6 @@ impl ESTree for WithClause<'_> {
fn serialize<S: Serializer>(&self, serializer: S) {
let mut state = serializer.serialize_struct();
state.serialize_field("attributes", &self.with_entries);
state.serialize_span(self.span);
state.end();
}
}
Expand Down
6 changes: 1 addition & 5 deletions napi/parser/src-js/generated/deserialize/js.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2066,11 +2066,7 @@ function deserializeImportNamespaceSpecifier(pos) {
}

function deserializeWithClause(pos) {
return {
attributes: deserializeVecImportAttribute(pos + 8),
start: deserializeU32(pos),
end: deserializeU32(pos + 4),
};
return { attributes: deserializeVecImportAttribute(pos + 8) };
}

function deserializeImportAttribute(pos) {
Expand Down
6 changes: 1 addition & 5 deletions napi/parser/src-js/generated/deserialize/js_parent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2324,11 +2324,7 @@ function deserializeImportNamespaceSpecifier(pos) {
}

function deserializeWithClause(pos) {
return {
attributes: deserializeVecImportAttribute(pos + 8),
start: deserializeU32(pos),
end: deserializeU32(pos + 4),
};
return { attributes: deserializeVecImportAttribute(pos + 8) };
}

function deserializeImportAttribute(pos) {
Expand Down
8 changes: 1 addition & 7 deletions napi/parser/src-js/generated/deserialize/js_range.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2306,13 +2306,7 @@ function deserializeImportNamespaceSpecifier(pos) {
}

function deserializeWithClause(pos) {
let start, end;
return {
attributes: deserializeVecImportAttribute(pos + 8),
start: (start = deserializeU32(pos)),
end: (end = deserializeU32(pos + 4)),
range: [start, end],
};
return { attributes: deserializeVecImportAttribute(pos + 8) };
}

function deserializeImportAttribute(pos) {
Expand Down
8 changes: 1 addition & 7 deletions napi/parser/src-js/generated/deserialize/js_range_parent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2567,13 +2567,7 @@ function deserializeImportNamespaceSpecifier(pos) {
}

function deserializeWithClause(pos) {
let start, end;
return {
attributes: deserializeVecImportAttribute(pos + 8),
start: (start = deserializeU32(pos)),
end: (end = deserializeU32(pos + 4)),
range: [start, end],
};
return { attributes: deserializeVecImportAttribute(pos + 8) };
}

function deserializeImportAttribute(pos) {
Expand Down
6 changes: 1 addition & 5 deletions napi/parser/src-js/generated/deserialize/ts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2317,11 +2317,7 @@ function deserializeImportNamespaceSpecifier(pos) {
}

function deserializeWithClause(pos) {
return {
attributes: deserializeVecImportAttribute(pos + 8),
start: deserializeU32(pos),
end: deserializeU32(pos + 4),
};
return { attributes: deserializeVecImportAttribute(pos + 8) };
}

function deserializeImportAttribute(pos) {
Expand Down
6 changes: 1 addition & 5 deletions napi/parser/src-js/generated/deserialize/ts_parent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2590,11 +2590,7 @@ function deserializeImportNamespaceSpecifier(pos) {
}

function deserializeWithClause(pos) {
return {
attributes: deserializeVecImportAttribute(pos + 8),
start: deserializeU32(pos),
end: deserializeU32(pos + 4),
};
return { attributes: deserializeVecImportAttribute(pos + 8) };
}

function deserializeImportAttribute(pos) {
Expand Down
8 changes: 1 addition & 7 deletions napi/parser/src-js/generated/deserialize/ts_range.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2582,13 +2582,7 @@ function deserializeImportNamespaceSpecifier(pos) {
}

function deserializeWithClause(pos) {
let start, end;
return {
attributes: deserializeVecImportAttribute(pos + 8),
start: (start = deserializeU32(pos)),
end: (end = deserializeU32(pos + 4)),
range: [start, end],
};
return { attributes: deserializeVecImportAttribute(pos + 8) };
}

function deserializeImportAttribute(pos) {
Expand Down
8 changes: 1 addition & 7 deletions napi/parser/src-js/generated/deserialize/ts_range_parent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2854,13 +2854,7 @@ function deserializeImportNamespaceSpecifier(pos) {
}

function deserializeWithClause(pos) {
let start, end;
return {
attributes: deserializeVecImportAttribute(pos + 8),
start: (start = deserializeU32(pos)),
end: (end = deserializeU32(pos + 4)),
range: [start, end],
};
return { attributes: deserializeVecImportAttribute(pos + 8) };
}

function deserializeImportAttribute(pos) {
Expand Down
12 changes: 0 additions & 12 deletions napi/parser/src-js/generated/lazy/constructors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5800,16 +5800,6 @@ export class WithClause {
nodes.set(pos, this);
}

get start() {
const internal = this.#internal;
return constructU32(internal.pos, internal.ast);
}

get end() {
const internal = this.#internal;
return constructU32(internal.pos + 4, internal.ast);
}

get attributes() {
const internal = this.#internal,
cached = internal.$attributes;
Expand All @@ -5819,8 +5809,6 @@ export class WithClause {

toJSON() {
return {
start: this.start,
end: this.end,
attributes: this.attributes,
};
}
Expand Down
Loading