fix(linter/no-noninteractive-tabindex): handle numeric tabIndex values on non-interactive elements

[camc314]

fixes #20471

[camc314]

• fix(linter/no-noninteractive-tabindex): handle numeric tabIndex values on non-interactive elements #20538 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull request overview

Fixes jsx-a11y/no-noninteractive-tabindex so it also flags non-interactive elements when tabIndex is provided as a numeric JSX expression (e.g. tabIndex={0}), aligning behavior with React’s tabIndex?: number typing and the linked issue.

Changes:

• Parse tabIndex values beyond just string literals (handles numeric expression containers like {0}).
• Tighten rule applicability to native DOM tags (via HTML_TAG) and keep early exits for interactive elements / allowed tags / allowed roles.
• Update rule tests and snapshot output to cover the newly-detected failing cases.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
crates/oxc_linter/src/rules/jsx_a11y/no_noninteractive_tabindex.rs	Extends tabIndex value parsing to numeric expressions and adjusts role handling logic / DOM-tag gating.
crates/oxc_linter/src/snapshots/jsx_a11y_no_noninteractive_tabindex.snap	Updates expected diagnostics to include the new failing cases (e.g. tabIndex={0}).

[codspeed-hq]

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 52 skipped benchmarks¹

---

_{Comparing c/03-19-fix_linter_no-noninteractive-tabindex_handle_numeric_tabindex_values_on_non-interactive_elements (8b6c3b1) with main (57b2e82)²}

Footnotes

1. 52 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

2. No successful run was found on main (2c50654) during the generation of this report, so 57b2e82 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

[camc314]

Merge activity

• Mar 19, 11:40 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Mar 19, 11:43 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Mar 19, 11:49 PM UTC: Merged by the Graphite merge queue.