Skip to content

fix(formatter,oxfmt): Sort imports should not flush Empty line#20443

Merged
graphite-app[bot] merged 1 commit intomainfrom
03-17-fix_formatter_oxfmt_sort_imports_should_not_flush_empty_line
Mar 17, 2026
Merged

fix(formatter,oxfmt): Sort imports should not flush Empty line#20443
graphite-app[bot] merged 1 commit intomainfrom
03-17-fix_formatter_oxfmt_sort_imports_should_not_flush_empty_line

Conversation

@leaysgur
Copy link
Copy Markdown
Member

@leaysgur leaysgur commented Mar 17, 2026

Fixes #20428

Since we're already handling the explicit LineMode::Empty, LineMode::Hard alone would have sufficed in this case.

@leaysgur leaysgur requested a review from Dunqing as a code owner March 17, 2026 02:20
@pullfrog
Copy link
Copy Markdown

pullfrog bot commented Mar 17, 2026

This run croaked 😵

The workflow encountered an error before any progress could be reported. Please check the link below for details.

Pullfrog  | Rerun failed job ➔View workflow run | Triggered by Pullfrogpullfrog.com𝕏

Copy link
Copy Markdown
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-cli Area - CLI A-formatter Area - Formatter C-bug Category - Bug labels Mar 17, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 17, 2026

Merging this PR will not alter performance

✅ 49 untouched benchmarks
⏩ 7 skipped benchmarks1


Comparing 03-17-fix_formatter_oxfmt_sort_imports_should_not_flush_empty_line (c111b95) with main (6a307d1)

Open in CodSpeed

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@leaysgur leaysgur added the 0-merge Merge with Graphite Merge Queue label Mar 17, 2026
Copy link
Copy Markdown
Member Author

leaysgur commented Mar 17, 2026

Merge activity

Fixes #20428

Since we're already handling the explicit `LineMode::Empty`, `LineMode::Hard` alone would have sufficed in this case.
@graphite-app graphite-app bot force-pushed the 03-17-fix_formatter_oxfmt_sort_imports_should_not_flush_empty_line branch from c111b95 to 71628e6 Compare March 17, 2026 02:36
@graphite-app graphite-app bot merged commit 71628e6 into main Mar 17, 2026
21 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 17, 2026
@graphite-app graphite-app bot deleted the 03-17-fix_formatter_oxfmt_sort_imports_should_not_flush_empty_line branch March 17, 2026 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-formatter Area - Formatter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

oxfmt: v0.41.0 regression, sortImports will insert extra empty lines in vue <script>

1 participant