fix(tsgolint): use primary span for the disable directive

[camc314]

fixes oxc-project/tsgolint#769

[camc314]

• fix(tsgolint): use primary span for the disable directive #20436 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[pullfrog]

This run croaked 😵

The workflow encountered an error before any progress could be reported. Please check the link below for details.

  ^{｜ Rerun failed job ➔ ｜ View workflow run ｜ Triggered by Pullfrog ｜ pullfrog.com ｜ 𝕏}

[Copilot]

Pull request overview

This PR improves how oxlint applies oxlint-disable-* directives to type-aware (tsgolint) diagnostics when those diagnostics include labeled ranges, and extends the CLI fixture coverage for that case.

Changes:

• Update tsgolint disable-directive span selection to prefer the diagnostic’s main span when present, falling back to the first labeled range only when the main span is unspanned.
• Extend the existing CLI snapshot test to lint an additional fixture file that exercises the labeled-ranges disable-directive scenario.
• Add a new TypeScript fixture file covering typescript/no-unnecessary-type-parameters with an oxlint-disable-next-line directive.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
crates/oxc_linter/src/tsgolint.rs	Adjusts which span is used when checking whether a tsgolint diagnostic should be suppressed by disable directives.
apps/oxlint/src/lint.rs	Updates the CLI snapshot test arguments to include a new fixture file in the run.
apps/oxlint/fixtures/cli/tsgolint_disable_directives/no-unnecessary-type-parameters-disable.ts	Adds fixture content to validate disable directives for a labeled-ranges tsgolint diagnostic.

---

You can also share your feedback on Copilot code review. Take the survey.

[codspeed-hq]

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 52 skipped benchmarks¹

---

_{Comparing c/03-16-fix_tsgolint_use_primary_span_for_the_disable_directive (0c57312) with main (5c104ff)²}

Footnotes

1. 52 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

2. No successful run was found on main (b82d37c) during the generation of this report, so 5c104ff was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[graphite-app]

Merge activity

• Mar 16, 7:51 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Mar 16, 8:03 PM UTC: Merged by the Graphite merge queue.

[Copilot]

Pull request overview

This PR adjusts how type-aware (tsgolint) diagnostics are matched against inline disable directives, and adds a regression fixture to ensure disable directives still work when tsgolint emits labeled ranges.

Changes:

• Update should_skip_diagnostic to prefer the main diagnostic span, falling back to the first labeled range only when the main span is unspanned.
• Update the CLI snapshot test invocation for tsgolint disable-directive behavior.
• Add a new fixture file covering a labeled-ranges disable-directive scenario.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
crates/oxc_linter/src/tsgolint.rs	Refines span selection used to decide whether a tsgolint diagnostic should be suppressed by disable directives.
apps/oxlint/src/lint.rs	Adjusts the tsgolint disable-directives snapshot test arguments.
apps/oxlint/fixtures/cli/tsgolint_disable_directives/no-unnecessary-type-parameters-disable.ts	Adds a regression fixture demonstrating disable directives with labeled-range diagnostics.

---

You can also share your feedback on Copilot code review. Take the survey.