Skip to content

fix(transformer): use implementation signature for design:paramtypes when constructor is overloaded#20394

Merged
Dunqing merged 1 commit intooxc-project:mainfrom
babu-ch:fix/transformer-legacy-decorator-metadata-constructor-overload
Mar 15, 2026
Merged

fix(transformer): use implementation signature for design:paramtypes when constructor is overloaded#20394
Dunqing merged 1 commit intooxc-project:mainfrom
babu-ch:fix/transformer-legacy-decorator-metadata-constructor-overload

Conversation

@babu-ch
Copy link
Contributor

@babu-ch babu-ch commented Mar 15, 2026

fixes #20369

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Mar 15, 2026
@babu-ch babu-ch changed the title fix(transformer): use implementation signature for design:paramtypes when constructor is overloaded fix(transformer): use implementation signature for design:paramtypes when constructor is overloaded Mar 15, 2026
@github-actions github-actions bot added the C-bug Category - Bug label Mar 15, 2026
@babu-ch babu-ch force-pushed the fix/transformer-legacy-decorator-metadata-constructor-overload branch from b0ec28d to 2e212b9 Compare March 15, 2026 08:50
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 15, 2026

Merging this PR will not alter performance

✅ 49 untouched benchmarks
⏩ 7 skipped benchmarks1


Comparing babu-ch:fix/transformer-legacy-decorator-metadata-constructor-overload (2e212b9) with main (ed5a7fb)

Open in CodSpeed

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Member

@Dunqing Dunqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! That's clear!

@Dunqing Dunqing merged commit fa70d5c into oxc-project:main Mar 15, 2026
28 checks passed
@babu-ch babu-ch deleted the fix/transformer-legacy-decorator-metadata-constructor-overload branch March 16, 2026 02:37
camc314 pushed a commit that referenced this pull request Mar 16, 2026
### 🐛 Bug Fixes

- edb8677 ecmascript: Treat collection constructor with variable arg as side-effectful (#20383) (Dunqing)
- 1f65c3f transformer: Emit design:paramtypes when class has static anonymous class expression (#20382) (bab)
- fa70d5c transformer: Use implementation signature for design:paramtypes when constructor is overloaded (#20394) (bab)
- ed5a7fb parser: Report syntax error for `new super()` (#20384) (Boshen)
- e62524d minifier: Treat object spread of getters as having side effects (#20380) (Boshen)
- f8fbd6e linter/plugins: Remove `hashbang` property from AST (#20365) (overlookmotel)

### ⚡ Performance

- 30a2b0f minifier: Use atom_from_strs_array for template literal concat (#20386) (Boshen)
- 690ce17 minifier: Use Vec::with_capacity for inline template expressions (#20389) (Boshen)
- 9cd612f linter/plugins: Recycle comment objects (#20362) (overlookmotel)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

transformer: design:paramtypes is calculated by the first overload signature instead of the implementation signature

2 participants