refactor(linter/plugins): move comments methods into own file#20363
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 14, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 14, 2026
github-actions
bot
added
A-linter
Contributor
There was a problem hiding this comment.
Pull request overview
A pure refactor that extracts SourceCode comment-related methods from comments.ts into a dedicated comments_methods.ts file, mirroring the existing pattern of tokens.ts / tokens_methods.ts. A small safety check is also added to the inline_search build plugin.
Changes:
- Moved comment query methods (
getAllComments,getCommentsBefore,getCommentsAfter,getCommentsInside,commentsExistBetween,getJSDocComment) into a newcomments_methods.tsfile. - Updated imports in
source_code.tsand theinline_searchtsdown plugin to reference the new file path. - Added a build-time assertion in
inline_search.tsto fail if nofirstTokenAtOrAftercalls are found for inlining.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
apps/oxlint/src-js/plugins/comments_methods.ts |
New file containing comment-related SourceCode methods moved from comments.ts |
apps/oxlint/src-js/plugins/comments.ts |
Removed moved methods; updated module-level comment |
apps/oxlint/src-js/plugins/source_code.ts |
Updated commentMethods import to point to comments_methods.ts |
apps/oxlint/tsdown_plugins/inline_search.ts |
Updated FILES path and added a safety check for zero inlined calls |
Contributor
Merge activity
|
graphite-app
bot
force-pushed
the
om/03-13-perf_linter_plugins_recycle_comment_objects
branch
from
9a256b8 to
53acd73
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Mar 14, 2026
Pure refactor. Move `sourceCode` methods related to comments into a separate file `comments_methods.ts`. Does not alter any of the code, just moves it.
graphite-app
bot
force-pushed
the
om/03-13-refactor_linter_plugins_move_comments_methods_into_own_file
branch
from
70b2361 to
159c3e2
Compare
Pure refactor. Move `sourceCode` methods related to comments into a separate file `comments_methods.ts`. Does not alter any of the code, just moves it.
graphite-app
bot
force-pushed
the
om/03-13-perf_linter_plugins_recycle_comment_objects
branch
from
53acd73 to
9cd612f
Compare
graphite-app
bot
force-pushed
the
om/03-13-refactor_linter_plugins_move_comments_methods_into_own_file
branch
from
159c3e2 to
ef41ffa
Compare
Base automatically changed from
om/03-13-perf_linter_plugins_recycle_comment_objects
to
main
March 14, 2026 12:31
graphite-app
bot
deleted the
om/03-13-refactor_linter_plugins_move_comments_methods_into_own_file
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor. Move
sourceCodemethods related to comments into a separate filecomments_methods.ts. Does not alter any of the code, just moves it.