Skip to content

perf(semantic): V8-style walk-up reference resolution #20292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Mar 13, 2026
Merged

perf(semantic): V8-style walk-up reference resolution #20292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions crates/oxc_linter/src/snapshots/jest_no_confusing_set_timeout.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,15 +43,15 @@ source: crates/oxc_linter/src/tester.rs
11 │
╰────

⚠ eslint-plugin-jest(no-confusing-set-timeout): `jest.setTimeout` should only be called in a global scope
⚠ eslint-plugin-jest(no-confusing-set-timeout): `jest.setTimeout` should be placed before any other jest methods.
╭─[no_confusing_set_timeout.tsx:3:21]
2 │ describe('A', () => {
3 │ jest.setTimeout(800);
· ───────────────
4 │ beforeEach(async () => { await new Promise(resolve => { setTimeout(resolve, 10000).unref(); });});
╰────

⚠ eslint-plugin-jest(no-confusing-set-timeout): `jest.setTimeout` should be placed before any other jest methods.
⚠ eslint-plugin-jest(no-confusing-set-timeout): `jest.setTimeout` should only be called in a global scope
╭─[no_confusing_set_timeout.tsx:3:21]
2 │ describe('A', () => {
3 │ jest.setTimeout(800);
Expand All @@ -67,15 +67,15 @@ source: crates/oxc_linter/src/tester.rs
6 │ setTimeout(resolve, 10000).unref();
╰────

⚠ eslint-plugin-jest(no-confusing-set-timeout): `jest.setTimeout` should only be called in a global scope
⚠ eslint-plugin-jest(no-confusing-set-timeout): `jest.setTimeout` should be placed before any other jest methods.
╭─[no_confusing_set_timeout.tsx:5:25]
4 │ await new Promise((resolve) => {
5 │ jest.setTimeout(1000);
· ───────────────
6 │ setTimeout(resolve, 10000).unref();
╰────

⚠ eslint-plugin-jest(no-confusing-set-timeout): `jest.setTimeout` should be placed before any other jest methods.
⚠ eslint-plugin-jest(no-confusing-set-timeout): `jest.setTimeout` should only be called in a global scope
╭─[no_confusing_set_timeout.tsx:5:25]
4 │ await new Promise((resolve) => {
5 │ jest.setTimeout(1000);
Expand Down
16 changes: 8 additions & 8 deletions crates/oxc_linter/src/snapshots/jest_prefer_lowercase_title@jest.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,19 +225,19 @@ source: crates/oxc_linter/src/tester.rs
help: `"Does things"`s should begin with lowercase

⚠ eslint-plugin-jest(prefer-lowercase-title): Enforce lowercase test names
╭─[prefer_lowercase_title.tsx:3:30]
╭─[prefer_lowercase_title.tsx:2:26]
1 │
2 │ describe('MyClass', () => {
· ─────────
3 │ describe('MyMethod', () => {
· ──────────
4 │ it('Does things', () => {
╰────
help: `"MyMethod"`s should begin with lowercase
help: `"MyClass"`s should begin with lowercase

⚠ eslint-plugin-jest(prefer-lowercase-title): Enforce lowercase test names
╭─[prefer_lowercase_title.tsx:2:26]
1 │
╭─[prefer_lowercase_title.tsx:3:30]
2 │ describe('MyClass', () => {
· ─────────
3 │ describe('MyMethod', () => {
· ──────────
4 │ it('Does things', () => {
╰────
help: `"MyClass"`s should begin with lowercase
help: `"MyMethod"`s should begin with lowercase
80 changes: 40 additions & 40 deletions crates/oxc_linter/src/snapshots/jest_valid_describe_callback.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,18 +162,6 @@ source: crates/oxc_linter/src/tester.rs
╰────
help: Remove return statement in your describe callback

⚠ eslint-plugin-jest(valid-describe-callback): Unexpected return statement in describe callback
╭─[valid_describe_callback.tsx:9:21]
8 │ describe('nested', () => {
9 │ ╭─▶ return Promise.resolve().then(() => {
10 │ │ it('breaks', () => {
11 │ │ throw new Error('Fail')
12 │ │ })
13 │ ╰─▶ })
14 │ })
╰────
help: Remove return statement in your describe callback

⚠ eslint-plugin-jest(valid-describe-callback): Unexpected return statement in describe callback
╭─[valid_describe_callback.tsx:3:17]
2 │ describe('foo', () => {
Expand All @@ -187,14 +175,14 @@ source: crates/oxc_linter/src/tester.rs
help: Remove return statement in your describe callback

⚠ eslint-plugin-jest(valid-describe-callback): Unexpected return statement in describe callback
╭─[valid_describe_callback.tsx:6:21]
5 │ describe('nested', () => {
6 │ ╭─▶ return Promise.resolve().then(() => {
7 │ │ it('breaks', () => {
8 │ │ throw new Error('Fail')
9 │ │ })
10 │ ╰─▶ })
11 │ })
╭─[valid_describe_callback.tsx:9:21]
8 │ describe('nested', () => {
9 │ ╭─▶ return Promise.resolve().then(() => {
10 │ │ it('breaks', () => {
11 │ │ throw new Error('Fail')
12 │ │ })
13 │ ╰─▶ })
14 │ })
╰────
help: Remove return statement in your describe callback

Expand All @@ -216,6 +204,18 @@ source: crates/oxc_linter/src/tester.rs
╰────
help: Remove `async` keyword

⚠ eslint-plugin-jest(valid-describe-callback): Unexpected return statement in describe callback
╭─[valid_describe_callback.tsx:6:21]
5 │ describe('nested', () => {
6 │ ╭─▶ return Promise.resolve().then(() => {
7 │ │ it('breaks', () => {
8 │ │ throw new Error('Fail')
9 │ │ })
10 │ ╰─▶ })
11 │ })
╰────
help: Remove return statement in your describe callback

⚠ eslint-plugin-jest(valid-describe-callback): Unexpected return statement in describe callback
╭─[valid_describe_callback.tsx:1:23]
1 │ describe('foo', () => test('bar', () => {}))
Expand Down Expand Up @@ -409,18 +409,6 @@ source: crates/oxc_linter/src/tester.rs
╰────
help: Remove return statement in your describe callback

⚠ eslint-plugin-jest(valid-describe-callback): Unexpected return statement in describe callback
╭─[valid_describe_callback.tsx:9:25]
8 │ describe('nested', () => {
9 │ ╭─▶ return Promise.resolve().then(() => {
10 │ │ it('breaks', () => {
11 │ │ throw new Error('Fail')
12 │ │ })
13 │ ╰─▶ })
14 │ })
╰────
help: Remove return statement in your describe callback

⚠ eslint-plugin-jest(valid-describe-callback): Unexpected return statement in describe callback
╭─[valid_describe_callback.tsx:3:21]
2 │ describe('foo', () => {
Expand All @@ -434,14 +422,14 @@ source: crates/oxc_linter/src/tester.rs
help: Remove return statement in your describe callback

⚠ eslint-plugin-jest(valid-describe-callback): Unexpected return statement in describe callback
╭─[valid_describe_callback.tsx:6:25]
5 │ describe('nested', () => {
6 │ ╭─▶ return Promise.resolve().then(() => {
7 │ │ it('breaks', () => {
8 │ │ throw new Error('Fail')
9 │ │ })
10 │ ╰─▶ })
11 │ })
╭─[valid_describe_callback.tsx:9:25]
8 │ describe('nested', () => {
9 │ ╭─▶ return Promise.resolve().then(() => {
10 │ │ it('breaks', () => {
11 │ │ throw new Error('Fail')
12 │ │ })
13 │ ╰─▶ })
14 │ })
╰────
help: Remove return statement in your describe callback

Expand All @@ -463,6 +451,18 @@ source: crates/oxc_linter/src/tester.rs
╰────
help: Remove `async` keyword

⚠ eslint-plugin-jest(valid-describe-callback): Unexpected return statement in describe callback
╭─[valid_describe_callback.tsx:6:25]
5 │ describe('nested', () => {
6 │ ╭─▶ return Promise.resolve().then(() => {
7 │ │ it('breaks', () => {
8 │ │ throw new Error('Fail')
9 │ │ })
10 │ ╰─▶ })
11 │ })
╰────
help: Remove return statement in your describe callback

⚠ eslint-plugin-jest(valid-describe-callback): Unexpected return statement in describe callback
╭─[valid_describe_callback.tsx:3:21]
2 │ describe('foo', () =>
Expand Down
2 changes: 0 additions & 2 deletions crates/oxc_semantic/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ oxc_allocator = { workspace = true }
oxc_ast = { workspace = true }
oxc_ast_visit = { workspace = true }
oxc_cfg = { workspace = true, optional = true }
oxc_data_structures = { workspace = true, features = ["assert_unchecked"] }
oxc_diagnostics = { workspace = true }
oxc_ecmascript = { workspace = true }
oxc_index = { workspace = true }
Expand All @@ -36,7 +35,6 @@ itertools = { workspace = true }
memchr = { workspace = true }
rustc-hash = { workspace = true }
self_cell = { workspace = true }
smallvec = { workspace = true }

[dev-dependencies]
insta = { workspace = true, features = ["glob"] }
Expand Down
Loading
Loading