fix(tools): disable TypeScript in VS Code#20287
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull request overview
Disables VS Code’s built-in TypeScript diagnostics for this repository to avoid duplicate/incorrect editor error reporting, relying instead on the Oxc language server (Oxlint type-aware checking).
Changes:
- Adds a VS Code workspace setting intended to turn off JS/TS validation diagnostics from VS Code/TypeScript.
- Documents why TS validation is disabled (TS version mismatches vs Oxlint/tsgolint).
| }, | ||
| // Disable TypeScript's error checking — Oxlint handles this via the Oxc language server. | ||
| // VS Code's bundled TS version can disagree with Oxlint's newer TS support (via tsgolint). | ||
| "js/ts.validate.enabled": false, |
There was a problem hiding this comment.
The setting key js/ts.validate.enabled doesn’t match VS Code’s built-in JS/TS validation settings, so this likely has no effect. To actually disable diagnostics from the TypeScript language service, use "typescript.validate.enable": false (and optionally "javascript.validate.enable": false if you also want JS files to stop showing TS-server validation errors).
| "js/ts.validate.enabled": false, | |
| "typescript.validate.enable": false, | |
| "javascript.validate.enable": false, |
There was a problem hiding this comment.
The settings you suggest are out of date. js/ts.validate.enabled is the setting in current VS Code.
camc314
left a comment
There was a problem hiding this comment.
We don't run typecheck when linting inside the editor, as we rely on the language server for this, so it'll probably cause missing diagnostics
|
Oh dammit you're right! |

Disable TypeScript type-checking in VS Code in this repo. It's redundant because Oxc language server runs Oxlint, which performs type-checking.
It's also annoying having TS enabled because the versions of TypeScript used by VS Code and by Oxlint sometimes disagree (e.g. on whether
RegExp.escapeexists), which produces erroneous red squiggles in some cases.This makes #20077 redundant.