Skip to content

perf(linter/plugins): reduce array lookups in visitor compilation #20249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Mar 12, 2026
+4 −2
Merged

perf(linter/plugins): reduce array lookups in visitor compilation #20249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions apps/oxlint/src-js/plugins/visitor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,9 +489,11 @@ export function finalizeCompiledVisitor(): VisitorState {

// Reset `visitPropsCache`.
// Setting these properties to `null` is not necessary for correctness, but it allows them to be garbage collected.
// `specificity` is only an SMI (stored inline), and is overwritten in `addVisitorToCompiled`, so no need to reset it.
for (let i = visitPropsCacheNextIndex - 1; i >= 0; i--) {
visitPropsCache[i].fn = null;
visitPropsCache[i].selectorStr = null;
const visitProp = visitPropsCache[i];
visitProp.fn = null;
visitProp.selectorStr = null;
}
visitPropsCacheNextIndex = 0;

Expand Down
Loading