-
-
Notifications
You must be signed in to change notification settings - Fork 900
feat(oxlint): Support vite.config.ts .lint field
#20214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
graphite-app
merged 1 commit into
main
from
03-11-feat_oxlint_support_vite.config.ts.lint_field
Mar 11, 2026
+171
−19
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,7 @@ use oxc_diagnostics::OxcDiagnostic; | |
| use oxc_linter::Oxlintrc; | ||
|
|
||
| use crate::run::JsLoadJsConfigsCb; | ||
| use crate::{VITE_CONFIG_NAME, VITE_OXLINT_CONFIG_FIELD}; | ||
|
|
||
| /// Callback type for loading JavaScript/TypeScript config files. | ||
| pub type JsConfigLoaderCb = | ||
|
|
@@ -118,7 +119,27 @@ fn parse_js_config_response(json: &str) -> Result<Vec<JsConfigResult>, Vec<OxcDi | |
| (Vec::with_capacity(count), Vec::new()), | ||
| |(mut configs, mut errors), entry| { | ||
| let path = PathBuf::from(&entry.path); | ||
| let mut oxlintrc = match parse_js_oxlintrc(entry.config) { | ||
|
|
||
| // Vite config files: extract the `.lint` field | ||
| let is_vite_config = path | ||
| .file_name() | ||
| .and_then(|f| f.to_str()) | ||
| .is_some_and(|name| name == VITE_CONFIG_NAME); | ||
| let config_value = if is_vite_config { | ||
| if let Some(v) = entry.config.get(VITE_OXLINT_CONFIG_FIELD).cloned() { | ||
| v | ||
| } else { | ||
| errors.push(OxcDiagnostic::error(format!( | ||
| "Expected a `{VITE_OXLINT_CONFIG_FIELD}` field in the default export of {}", | ||
| entry.path | ||
| ))); | ||
| return (configs, errors); | ||
| } | ||
| } else { | ||
| entry.config | ||
| }; | ||
|
|
||
| let mut oxlintrc = match parse_js_oxlintrc(config_value) { | ||
|
Comment on lines
+122
to
+142
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we should do this on the JS side to avoid sending excess data to rust. |
||
| Ok(config) => config, | ||
| Err(err) => { | ||
| errors.push( | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| debugger; | ||
| if (x == 1) { | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "singleThread": true | ||
| } |
29 changes: 29 additions & 0 deletions
29
apps/oxlint/test/fixtures/vite_config_basic/output.snap.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # Exit code | ||
| 1 | ||
|
|
||
| # stdout | ||
| ``` | ||
| x eslint(no-debugger): `debugger` statement is not allowed | ||
| ,-[files/test.js:1:1] | ||
| 1 | debugger; | ||
| : ^^^^^^^^^ | ||
| 2 | if (x == 1) { | ||
| `---- | ||
| help: Remove the debugger statement | ||
| ! eslint(eqeqeq): Expected === and instead saw == | ||
| ,-[files/test.js:2:7] | ||
| 1 | debugger; | ||
| 2 | if (x == 1) { | ||
| : ^^ | ||
| 3 | } | ||
| `---- | ||
| help: Prefer === operator | ||
| Found 1 warning and 1 error. | ||
| Finished in Xms on 1 file with 94 rules using X threads. | ||
| ``` | ||
|
|
||
| # stderr | ||
| ``` | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| export default { | ||
| lint: { | ||
| rules: { | ||
| "no-debugger": "error", | ||
| eqeqeq: "warn", | ||
| }, | ||
| }, | ||
| }; |
1 change: 1 addition & 0 deletions
1
apps/oxlint/test/fixtures/vite_config_no_lint_field/files/test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| debugger; |
3 changes: 3 additions & 0 deletions
3
apps/oxlint/test/fixtures/vite_config_no_lint_field/options.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "singleThread": true | ||
| } |
13 changes: 13 additions & 0 deletions
13
apps/oxlint/test/fixtures/vite_config_no_lint_field/output.snap.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # Exit code | ||
| 1 | ||
|
|
||
| # stdout | ||
| ``` | ||
| Failed to parse oxlint configuration file. | ||
|
|
||
| x Expected a `lint` field in the default export of <fixture>/vite.config.ts | ||
| ``` | ||
|
|
||
| # stderr | ||
| ``` | ||
| ``` |
3 changes: 3 additions & 0 deletions
3
apps/oxlint/test/fixtures/vite_config_no_lint_field/vite.config.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| export default { | ||
| plugins: [], | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| debugger; | ||
| if (x == 1) { | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "singleThread": true | ||
| } |
20 changes: 20 additions & 0 deletions
20
apps/oxlint/test/fixtures/vite_config_priority/output.snap.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| # Exit code | ||
| 1 | ||
|
|
||
| # stdout | ||
| ``` | ||
| x eslint(no-debugger): `debugger` statement is not allowed | ||
| ,-[files/test.js:1:1] | ||
| 1 | debugger; | ||
| : ^^^^^^^^^ | ||
| 2 | if (x == 1) { | ||
| `---- | ||
| help: Remove the debugger statement | ||
|
|
||
| Found 0 warnings and 1 error. | ||
| Finished in Xms on 1 file with 93 rules using X threads. | ||
| ``` | ||
|
|
||
| # stderr | ||
| ``` | ||
| ``` |
7 changes: 7 additions & 0 deletions
7
apps/oxlint/test/fixtures/vite_config_priority/oxlint.config.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| import { defineConfig } from "#oxlint"; | ||
|
|
||
| export default defineConfig({ | ||
| rules: { | ||
| "no-debugger": "error", | ||
| }, | ||
| }); |
7 changes: 7 additions & 0 deletions
7
apps/oxlint/test/fixtures/vite_config_priority/vite.config.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| export default { | ||
| lint: { | ||
| rules: { | ||
| eqeqeq: "warn", | ||
| }, | ||
| }, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to comment on a merged PR but I don't think this allows the
lintproperty to be optional - I'm seeingwhen I want this project to just use the default configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah this is a bug - please use the v1.52.0 in the interim
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#20237