test(linter/plugins): run rules in predictable order in tests#20165
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 10, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-linter
This was referenced Mar 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make JS-plugin rule execution order deterministic during tests, enabling multi-rule tests to reliably depend on rule run ordering.
Changes:
- In
lintFileImpl, reorder the(ruleIds, optionsIds)pairs underDEBUGto enforce a stable rule execution order. - Preserve correct Rust-side diagnostic mapping by setting each rule’s
ruleIndexto the original (pre-sort) position.
overlookmotel
force-pushed
the
om/03-09-test_linter_plugins_run_rules_in_predictable_order_in_tests
branch
from
fdb28de to
425b8be
Compare
Contributor
Merge activity
|
graphite-app
bot
force-pushed
the
om/03-09-test_linter_plugins_run_rules_in_predictable_order_in_tests
branch
from
425b8be to
3dabb8e
Compare
graphite-app
bot
deleted the
om/03-09-test_linter_plugins_run_rules_in_predictable_order_in_tests
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In tests, run rules in a predictable order (the order they're defined in config).
This makes it possible to control in tests with multiple rules in what order they run, which makes the tests in next 2 PRs (#20166, #20167) feasible.