feat(oxfmt): Add --config-field CLI option#20138
feat(oxfmt): Add --config-field CLI option#20138leaysgur wants to merge 1 commit into03-09-feat_oxfmt_.js_.ts_config_file_supportfrom
--config-field CLI option#20138Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
--config-field CLI option
feded2c to
4e6cca3
Compare
4e6cca3 to
45322e8
Compare
Sysix
left a comment
There was a problem hiding this comment.
I would like to have a intergration test for it. We created a similar js test setup for oxlint lsp :)
camc314
left a comment
There was a problem hiding this comment.
How is the LSP going to invoke this? Does it bypass the vscode extension? or some other way?
What about for non-vscode users? Do they manually have to configure this in the LS config?
|
@camc314 every client (IDE/editor) is responsible to configure the new configuration like the CLI. |
|
hmm @leaysgur shall we discuss this tomorow? I think we want this to be as low-friction as possible for vite+, and requireing a user to configure this doens't feel ideal |
45322e8 to
f0bd30d
Compare
b0ff1a0 to
7f1696f
Compare
|
We've decided to take a different approach, so closing. |

NOTE: I'd like to merge this in sync with
oxlint.