test(linter/plugins): add types test for `VisitorObject` by overlookmotel · Pull Request #20066 · oxc-project/oxc

overlookmotel · 2026-03-06T09:30:22Z

Add a types test for #20065. This is a separate PR as it depends on strict: true TS config option added in #19675.

overlookmotel · 2026-03-06T09:30:31Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

Adds a TypeScript type-level regression test around the VisitorObject typings (related to #20065), relying on the stricter TS configuration enabled in #19675.

Changes:

Add a new visitor.test-d.ts type assertion file for VisitorObject assignability cases.
Add @type-challenges/utils as a dev dependency to express compile-time assertions.
Update pnpm-lock.yaml to include the new dependency.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File	Description
pnpm-lock.yaml	Locks `@type-challenges/utils@0.1.1` for the workspace.
apps/oxlint/package.json	Adds `@type-challenges/utils` to enable type-level assertions.
apps/oxlint/src-js/visitor.test-d.ts	Introduces type-level cases intended to validate `VisitorObject` typing.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

apps/oxlint/package.json

Copilot

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

graphite-app · 2026-03-06T17:29:22Z

Merge activity

Mar 6, 5:29 PM UTC: camc314 added this pull request to the Graphite merge queue.
Mar 6, 5:29 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Mar 6, 5:38 PM UTC: Merged by the Graphite merge queue.

Add a types test for #20065. This is a separate PR as it depends on `strict: true` TS config option added in #19675.

Rename tokens type tests file to `.test-d.ts`, following the pattern set by #20066.

…20155) Remove `noUnusedLocals` option from `tsconfig.json` files. It's redundant, as Oxlint `no-unused-vars` covers this for us. It's an annoyance to have `noUnusedLocals` enabled, as in VS Code TypeScript complains about unused vars, even if they're prefixed with `_`. Removing this option allows simplifying type tests added in #20066. Only reason these types had to be exported was to stop TS complaining that they were unused.

This was referenced Mar 6, 2026

refactor(linter/plugins): enable TS strict option #19675

Merged

chore(apps, napi): restrict global types to NodeJS in tsconfig #20064

Closed

fix(linter/plugins): fix type definition for VisitorObject #20065

Merged

github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Mar 6, 2026

overlookmotel marked this pull request as ready for review March 6, 2026 09:38

overlookmotel requested a review from camc314 as a code owner March 6, 2026 09:38

Copilot AI review requested due to automatic review settings March 6, 2026 09:38

Copilot started reviewing on behalf of overlookmotel March 6, 2026 09:39 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

apps/oxlint/package.json Show resolved Hide resolved

overlookmotel force-pushed the om/03-06-test_linter_plugins_add_types_test_for_visitorobject_ branch from 42f72c3 to 63ddbdb Compare March 6, 2026 11:42

This was referenced Mar 6, 2026

refactor(linter/plugins): clarify types #20069

Merged

refactor(linter/plugins): debug assert that values passed via NAPI are not undefined #20070

Merged

overlookmotel force-pushed the 02-24-chore_apps_oxlint_enable_typescript_strict_option branch from 4495ed1 to e199f2d Compare March 6, 2026 14:37

overlookmotel force-pushed the om/03-06-test_linter_plugins_add_types_test_for_visitorobject_ branch from 63ddbdb to 8ee5a16 Compare March 6, 2026 14:37

overlookmotel mentioned this pull request Mar 6, 2026

fix(linter/plugins): define RegExp.escape for tsc #20077

Closed

overlookmotel force-pushed the om/03-06-test_linter_plugins_add_types_test_for_visitorobject_ branch from 8ee5a16 to f88a63f Compare March 6, 2026 15:37

overlookmotel force-pushed the 02-24-chore_apps_oxlint_enable_typescript_strict_option branch from e199f2d to 9904a4a Compare March 6, 2026 15:37

overlookmotel requested a review from Copilot March 6, 2026 15:45

Copilot started reviewing on behalf of overlookmotel March 6, 2026 15:45 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

graphite-app bot force-pushed the 02-24-chore_apps_oxlint_enable_typescript_strict_option branch 2 times, most recently from 9100c63 to cce88d5 Compare March 6, 2026 16:09

graphite-app bot force-pushed the om/03-06-test_linter_plugins_add_types_test_for_visitorobject_ branch from f88a63f to e4f3e09 Compare March 6, 2026 16:09

overlookmotel force-pushed the 02-24-chore_apps_oxlint_enable_typescript_strict_option branch from cce88d5 to a7ff967 Compare March 6, 2026 16:17

overlookmotel force-pushed the om/03-06-test_linter_plugins_add_types_test_for_visitorobject_ branch from e4f3e09 to cd83465 Compare March 6, 2026 16:17

overlookmotel mentioned this pull request Mar 6, 2026

linter: JS Plugins types for custom rules with createRule() seem incorrect #18154

Closed

This was referenced Mar 6, 2026

fix(linter/plugins): fix types for walkProgram and walkProgramWithCfg #20081

Merged

docs(linter/plugins): move comment about "bivariance hack" into generated code #20082

Merged

overlookmotel assigned camc314 Mar 6, 2026

camc314 approved these changes Mar 6, 2026

View reviewed changes

camc314 added the 0-merge Merge with Graphite Merge Queue label Mar 6, 2026

test(linter/plugins): add types test for VisitorObject (#20066)

aacfef4

Add a types test for #20065. This is a separate PR as it depends on `strict: true` TS config option added in #19675.

graphite-app bot force-pushed the 02-24-chore_apps_oxlint_enable_typescript_strict_option branch from a7ff967 to e255fcd Compare March 6, 2026 17:30

graphite-app bot force-pushed the om/03-06-test_linter_plugins_add_types_test_for_visitorobject_ branch from cd83465 to aacfef4 Compare March 6, 2026 17:30

Base automatically changed from 02-24-chore_apps_oxlint_enable_typescript_strict_option to main March 6, 2026 17:37

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 6, 2026

graphite-app bot merged commit aacfef4 into main Mar 6, 2026
20 checks passed

graphite-app bot deleted the om/03-06-test_linter_plugins_add_types_test_for_visitorobject_ branch March 6, 2026 17:38

overlookmotel mentioned this pull request Mar 9, 2026

test(linter/plugins): rename type test file #20153

Merged

graphite-app bot pushed a commit that referenced this pull request Mar 9, 2026

test(linter/plugins): rename type test file (#20153)

21ea2ae

Rename tokens type tests file to `.test-d.ts`, following the pattern set by #20066.

overlookmotel mentioned this pull request Mar 9, 2026

refactor(apps, napi, tasks): remove noUnusedLocals from tsconfigs #20155

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(linter/plugins): add types test for `VisitorObject`#20066

test(linter/plugins): add types test for `VisitorObject`#20066
graphite-app[bot] merged 1 commit intomainfrom
om/03-06-test_linter_plugins_add_types_test_for_visitorobject_

overlookmotel commented Mar 6, 2026 •

edited

Loading

Uh oh!

overlookmotel commented Mar 6, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

graphite-app bot commented Mar 6, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

overlookmotel commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

graphite-app bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

overlookmotel commented Mar 6, 2026 •

edited

Loading

overlookmotel commented Mar 6, 2026 •

edited

Loading

graphite-app bot commented Mar 6, 2026 •

edited

Loading