test(oxlint): move non lsp fixtures to fixtures/cli#20044
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 6, 2026
Merged
test(oxlint): move non lsp fixtures to fixtures/cli#20044graphite-app[bot] merged 1 commit intomainfrom
fixtures/cli#20044graphite-app[bot] merged 1 commit intomainfrom
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-linter
Sysix
force-pushed
the
03-05-test_oxlint_move_non_lsp_fixtures_to_fixtures_cli_
branch
3 times, most recently
from
cba92bb to
2810cfb
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Moves non-LSP oxlint fixtures into fixtures/cli and updates tests/snapshots to reference the new paths.
Changes:
- Updated CLI snapshot expectations to use
fixtures/cli/...paths. - Updated CLI-related Rust tests to run in / reference
fixtures/cli/.... - Updated config loader tests to point at the moved fixtures.
Reviewed changes
Copilot reviewed 15 out of 436 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/oxlint/src/snapshots/_-W no-undef -c fixtures__cli__no_undef__eslintrc.json fixtures__cli__no_undef__test.js@oxlint.snap | Snapshot updated to reference fixtures/cli/no_undef/... |
| apps/oxlint/src/snapshots/_-W no-undef -c fixtures__cli__eslintrc_env__eslintrc_no_env.json fixtures__cli__eslintrc_env__test.js@oxlint.snap | Snapshot updated to reference fixtures/cli/eslintrc_env/... |
| apps/oxlint/src/snapshots/_-W correctness -A no-debugger fixtures__cli__linter__debugger.js@oxlint.snap | Snapshot updated to reference fixtures/cli/linter/... |
| apps/oxlint/src/snapshots/_-D correctness fixtures__cli__linter__debugger.js@oxlint.snap | Snapshot updated to reference fixtures/cli/linter/... |
| apps/oxlint/src/snapshots/_-A all fixtures__cli__linter@oxlint.snap | Snapshot updated to reference fixtures/cli/linter |
| apps/oxlint/src/snapshots/_--vitest-plugin -c fixtures__cli__eslintrc_vitest_replace__eslintrc.json fixtures__cli__eslintrc_vitest_replace__foo.test.js@oxlint.snap | Snapshot updated to reference fixtures/cli/eslintrc_vitest_replace/... |
| apps/oxlint/src/snapshots/_--import-plugin fixtures__cli__flow__index.mjs@oxlint.snap | Snapshot updated to reference fixtures/cli/flow/... |
| apps/oxlint/src/snapshots/_--import-plugin -A all -D no-cycle fixtures__cli__flow__@oxlint.snap | Snapshot updated to reference fixtures/cli/flow/... |
| apps/oxlint/src/snapshots/_--ignore-pattern _____.js --ignore-pattern _____.vue fixtures__cli__linter@oxlint.snap | Snapshot updated to reference fixtures/cli/linter |
| apps/oxlint/src/snapshots/_--ignore-path fixtures__cli__linter__.customignore fixtures__cli__linter__nan.js@oxlint.snap | Snapshot updated to reference fixtures/cli/linter/... |
| apps/oxlint/src/snapshots/_--ignore-path fixtures__cli__linter__.customignore --no-ignore fixtures__cli__linter__nan.js@oxlint.snap | Snapshot updated to reference fixtures/cli/linter/... |
| apps/oxlint/src/snapshots/_--ignore-path fixtures__cli__issue_7566__.oxlintignore fixtures__cli__issue_7566__tests__main.js fixtures__cli__issue_7566__tests__function__main.js@oxlint.snap | Snapshot updated to reference fixtures/cli/issue_7566/... |
| apps/oxlint/src/output_formatter/mod.rs | Test cwd updated to fixtures/cli/output_formatter_diagnostic |
| apps/oxlint/src/lint.rs | CLI tests updated to run against fixtures/cli/... |
| apps/oxlint/src/config_loader.rs | Config loader tests updated to use fixtures/cli/... fixtures |
camc314
approved these changes
Mar 6, 2026
Contributor
Merge activity
|
Now there are only two folders in `apps/oxlint/fixtures`. We can later create another directory for both integrations (like config walker).
graphite-app
bot
force-pushed
the
03-05-test_oxlint_move_non_lsp_fixtures_to_fixtures_cli_
branch
from
2810cfb to
065a358
Compare
graphite-app
bot
deleted the
03-05-test_oxlint_move_non_lsp_fixtures_to_fixtures_cli_
branch
Member
Author
|
I think this broke windows CI, this fix should work: https://stackoverflow.com/a/22575737/7387397 |
graphite-app bot
pushed a commit
that referenced
this pull request
Mar 8, 2026
After #20044 the paths are too long for windows git. The windows CI is failing because of this: https://github.com/oxc-project/oxc/actions/runs/22763163089/job/66024371179 Solution found in https://stackoverflow.com/a/22575737/7387397 Should work again: https://github.com/oxc-project/oxc/actions/runs/22764481037/job/66028823796?pr=20075
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now there are only two folders in
apps/oxlint/fixtures.We can later create another directory for both integrations (like config walker).