Skip to content

feat(parser): report error for implements clause in non-ts files #19820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Boshen merged 1 commit into from
Feb 28, 2026
Merged

feat(parser): report error for implements clause in non-ts files #19820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions crates/oxc_parser/src/diagnostics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1121,6 +1121,11 @@ pub fn parameter_modifiers_in_ts(
.with_allowed_modifier_help(allowed)
}

#[cold]
pub fn implements_clause_in_ts(span: Span) -> OxcDiagnostic {
ts_error("8005", "'implements' clauses can only be used in TypeScript files.").with_label(span)
}

#[cold]
pub fn implementation_in_ambient(span: Span) -> OxcDiagnostic {
ts_error("1183", "An implementation cannot be declared in ambient contexts.").with_label(span)
Expand Down
3 changes: 3 additions & 0 deletions crates/oxc_parser/src/js/class.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,9 @@ impl<'a, C: Config> ParserImpl<'a, C> {
));
}
let implements_kw_span = self.cur_token().span();
if !self.is_ts {
self.error(diagnostics::implements_clause_in_ts(implements_kw_span));
}
if let Some((_, implements)) = implements.as_mut() {
implements.extend(self.parse_ts_implements_clause());
} else {
Expand Down
10 changes: 7 additions & 3 deletions tasks/coverage/snapshots/parser_typescript.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ commit: 34725489
parser_typescript Summary:
AST Parsed : 9831/9834 (99.97%)
Positive Passed: 9820/9834 (99.86%)
Negative Passed: 1527/2578 (59.23%)
Negative Passed: 1528/2578 (59.27%)
Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/FunctionDeclaration3.ts

Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/FunctionDeclaration4.ts
Expand Down Expand Up @@ -530,8 +530,6 @@ Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/jsFileCompil

Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/jsFileCompilationDuplicateFunctionImplementationFileOrderReversed.ts

Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/jsFileCompilationHeritageClauseSyntaxOfClass.ts

Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/jsFileCompilationOptionalClassElementSyntaxOfClass.ts

Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/jsFileCompilationPublicMethodSyntaxOfClass.ts
Expand Down Expand Up @@ -7370,6 +7368,12 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/parser/ecmasc
╰────
help: Add a function body (`{}`).

× TS(8005): 'implements' clauses can only be used in TypeScript files.
╭─[typescript/tests/cases/compiler/jsFileCompilationHeritageClauseSyntaxOfClass.ts:1:9]
1 │ class C implements D { }
· ──────────
╰────

× TS(8002): 'import ... =' can only be used in TypeScript files.
╭─[typescript/tests/cases/compiler/jsFileCompilationImportEqualsSyntax.ts:1:1]
1 │ import a = b;
Expand Down
Loading