test(oxfmt): Add snapshot for invalid file error reports#19802
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
C-test
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds snapshot tests for CLI error reporting when processing files with invalid syntax. The tests verify that the oxfmt CLI tool correctly reports syntax errors for both JavaScript and YAML files with parse errors.
Changes:
- Added test suite for error reporting with invalid file syntax
- Added fixture files with intentionally invalid JavaScript and YAML syntax
- Added snapshot capturing expected error output format
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/oxfmt/test/cli/error_reports/error_reports.test.ts | New test suite verifying CLI error reporting for invalid files |
| apps/oxfmt/test/cli/error_reports/fixtures/invalid.js | Fixture with invalid JavaScript syntax (incomplete class declaration) |
| apps/oxfmt/test/cli/error_reports/fixtures/invalid.yaml | Fixture with invalid YAML syntax (nested mappings in compact form) |
| apps/oxfmt/test/cli/error_reports/snapshots/error_reports.test.ts.snap | Snapshot capturing expected error messages and exit code |
Member
Author
Merge activity
|
leaysgur
force-pushed
the
02-27-test_oxfmt_add_snapshot_for_invalid_file_error_reports
branch
4 times, most recently
from
51a17c1 to
b94caf8
Compare
leaysgur
force-pushed
the
02-27-test_oxfmt_add_snapshot_for_invalid_file_error_reports
branch
3 times, most recently
from
aa98e9f to
70943d7
Compare
Just adding tests for sure. ..., but to do so, we need to force dumb theme for `miette`.
graphite-app
bot
force-pushed
the
02-27-test_oxfmt_add_snapshot_for_invalid_file_error_reports
branch
from
70943d7 to
e7572aa
Compare
graphite-app
bot
deleted the
02-27-test_oxfmt_add_snapshot_for_invalid_file_error_reports
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just adding tests for sure.
..., but to do so, we need to force dumb theme for
miette.