refactor(formatter,oxfmt): Remove EmbeddedIR and use FormatElement directly

[leaysgur]

Follow up on #19670 (comment)

It seems it was achievable without requiring such major changes.
Thank you for your suggestion! 🙏🏻

[leaysgur]

• refactor(formatter,oxfmt): Remove EmbeddedIR and use FormatElement directly #19800 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

Merging this PR will not alter performance

✅ 48 untouched benchmarks
⏩ 7 skipped benchmarks¹

---

_{Comparing 02-27-refactor_formatter_oxfmt_remove_embeddedir_and_use_formatelement_directly (94ac8e2) with main (9e4995c)}

Footnotes

1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull request overview

This PR refactors the embedded language formatting system by removing the intermediate EmbeddedIR type and using FormatElement<'a> directly. This is a follow-up to PR #19670, which introduced GraphQL-in-JS formatting support.

Changes:

• Removed the EmbeddedIR enum and its conversion logic from oxc_formatter
• Modified EmbeddedDocFormatterCallback to directly return Vec<FormatElement<'a>> instead of Vec<EmbeddedIR>
• Updated the callback to receive &Allocator and &UniqueGroupIdBuilder parameters for arena allocation and group ID management
• Made UniqueGroupIdBuilder public to support external group ID creation
• Moved escape_template_characters function from embed/mod.rs to from_prettier_doc.rs
• Updated GraphQL formatting to work directly with FormatElement<'a>
• Removed unit tests from from_prettier_doc.rs

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
crates/oxc_formatter/src/external_formatter.rs	Updated EmbeddedDocFormatterCallback signature to accept allocator/group_id_builder and return FormatElement<'a> directly; removed EmbeddedIR enum definition
crates/oxc_formatter/src/lib.rs	Exported additional types (Align, Condition, Group, GroupMode, Tag, TextWidth, UniqueGroupIdBuilder) needed by external callbacks
crates/oxc_formatter/src/formatter/state.rs	Added group_id_builder() accessor method
crates/oxc_formatter/src/formatter/mod.rs	Exported UniqueGroupIdBuilder publicly
crates/oxc_formatter/src/formatter/group_id.rs	Changed UniqueGroupIdBuilder visibility from pub(super) to pub
crates/oxc_formatter/src/formatter/formatter.rs	Added group_id_builder() accessor method
crates/oxc_formatter/src/formatter/format_element/tag.rs	Added #[must_use] attributes to builder methods; added Align::new() constructor
crates/oxc_formatter/src/print/template/embed/mod.rs	Removed write_embedded_ir() function and escape_template_characters() function (moved to from_prettier_doc.rs)
crates/oxc_formatter/src/print/template/embed/graphql.rs	Updated to work directly with Vec<FormatElement<'a>> instead of Vec<EmbeddedIR>; uses allocator for text allocation
apps/oxfmt/src/prettier_compat/from_prettier_doc.rs	Rewrote to convert Doc JSON directly to FormatElement<'a> instead of EmbeddedIR; added escape_template_characters() from embed/mod.rs; removed all unit tests
apps/oxfmt/src/core/external_formatter.rs	Updated callback invocation to pass allocator and group_id_builder parameters

[Dunqing]

Nice! I think this can also improve performance. I pushed a commit to avoid unnecessary cloning of IRs. Please also take a look at Copilot reviews before merging it

[leaysgur]

Thanks as always! 🫶

I've also made it compatible with Copilot reviews, so will merge it.

[leaysgur]

Merge activity

• Feb 27, 9:15 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Feb 27, 9:20 AM UTC: leaysgur added this pull request to the Graphite merge queue.
• Feb 27, 9:26 AM UTC: Merged by the Graphite merge queue.